safeparcel: Support short #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
requested changes
Aug 28, 2023
play-services-basement/src/main/java/org/microg/safeparcel/SafeParcelReflectionUtil.java
Outdated
Show resolved
Hide resolved
chirayudesai
force-pushed
the
safeparcel-short
branch
from
1c19198
to
82296fd
Compare
* Fixes crash with certain USB security keys, exception: FATAL EXCEPTION: main Process: com.google.android.gms:ui, PID: 6301 java.lang.ExceptionInInitializerError at java.lang.reflect.Field.get(Native Method) at org.microg.safeparcel.SafeParcelReflectionUtil.getCreator(SafeParcelReflectionUtil.java:123) at org.microg.safeparcel.SafeParcelReflectionUtil$ClassDescriptor$FieldDescriptor.<init>(SafeParcelReflectionUtil.java:465) at org.microg.safeparcel.SafeParcelReflectionUtil$ClassDescriptor.<init>(SafeParcelReflectionUtil.java:411) at org.microg.safeparcel.ReflectedSafeParcelableCreatorAndWriter.<init>(ReflectedSafeParcelableCreatorAndWriter.java:18) at org.microg.safeparcel.AutoSafeParcelable$AutoCreator.<init>(AutoSafeParcelable.java:45) at com.google.android.gms.fido.fido2.api.common.UvmEntries.<clinit>(UvmEntries.java:80) <snipped> Caused by: java.lang.RuntimeException: Type is not yet usable with SafeParcelReflectionUtil: short at org.microg.safeparcel.SafeParcelReflectionUtil$ClassDescriptor$FieldDescriptor.getType(SafeParcelReflectionUtil.java:521) Change-Id: Ie1c523d932ac213c531edf1e227c6ddcb72916bd
chirayudesai
force-pushed
the
safeparcel-short
branch
from
82296fd
to
626a20f
Compare
mar-v-in
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full stacktrace: https://zifb.in/raw/Q89aPk61T4
Tested using: https://demo.yubico.com/webauthn-technical/registration