Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the icon of microG settings inside Android settings on Android < 8, fix #2057 #2061

Closed

Conversation

ale5000-git
Copy link
Member

Fix the icon of microG settings inside Android settings on Android < 8, fix #2057

This is probably something left out from this commit: 90f8a6a

@Wojtaz0w
Copy link

does it fix issue created by me? #2059

@ale5000-git
Copy link
Member Author

Obviously no.
In the title there is "Android < 8" that mean "Android version less than 8", in this case in particular apply to:

Android 7.x
Android 6.x

@Wojtaz0w
Copy link

Nevermind, i didnt read that part of title... sorry

@ale5000-git
Copy link
Member Author

Don't worry, on newer Android it use a different file so they are completely separate.

@ale5000-git
Copy link
Member Author

ale5000-git commented Oct 3, 2023

@mar-v-in
I have also tried to reuse the drawable from here on Nougat: https://github.com/microg/GmsCore/blob/master/play-services-core/src/main/res/drawable-v26/ic_app_settings_foreground_mono.xml

It generally works but it is too much small and if I try to resize it then it get disaligned and truncated.
Since the benefit of vectorial images is to render correctly at any size I conclude that the xml is broken.

@mar-v-in
Copy link
Member

I added the missing icon via 44b9173

Not sure what issue you had with the vector drawable, but resizing it worked fine for me.

@mar-v-in mar-v-in closed this Oct 28, 2023
@ale5000-git ale5000-git removed the request for review from mar-v-in January 28, 2024 17:47
@ale5000-git ale5000-git deleted the patch-icon-fix-for-old-android branch January 28, 2024 17:48
@ale5000-git
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

microG settings icon inside Android settings is missing on Nougat
3 participants