Licensing UI #2076
Merged
Licensing UI #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
reviewed
Oct 24, 2023
There was a problem hiding this comment.
- Please add REUSE style copyright headers to newly added files
- I'd suggest to not call the setting (in code)
play, as this could mean either Play Store or Play Services. Maybe go forvendinginstead? - As we plan to soon have futher services in Play Store category, I don't think it makes sense to use the SwitchBar preference here, as it is not the primary action of this category (a normal switch preference should be enough)
|
@mar-v-in I've added new commits that address your points. |
mar-v-in
requested changes
Dec 16, 2023
mar-v-in
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI for enabling / disabling licensing, as requested in #2069 (comment).
Default: off.
SettingsProvideris now exposed and protected via two signature protected permissions,org.microg.gms.permission.READ_SETTINGSand.WRITE_SETTINGS. (I split up reading and writing so that, for example, we can relax.READ_SETTINGStosignatureOrSystemlater on in case a ROM finds use for accessing any microG settings.)I will add the code that checks for the preference to #2069 or a follow-up PR immediately after this PR is merged.