Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fido: Allow background activity launch #2082

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fido: Allow background activity launch #2082

merged 1 commit into from
Dec 12, 2023

Conversation

Uldiniad
Copy link
Contributor

@Uldiniad Uldiniad commented Nov 1, 2023

Fixes passkey creation

Change-Id: I49c97ad820be35dec1f32944361b4e3b617c1d0f

@Uldiniad
Fido: Allow background activity launch
03279a9 
Fixes passkey creation

Change-Id: I49c97ad820be35dec1f32944361b4e3b617c1d0f
@t-m-w
Copy link
Contributor

t-m-w commented Nov 29, 2023

Note that this fixes everything related to FIDO/Webauthn for Android 14 (so, not just passkey creation, but also authentication, and also security keys and device-as-security-key). These require presenting the registration or authentication activity to proceed, so they're not functional in Android 14 without this.

@mar-v-in mar-v-in merged commit e0c259d into microg:master Dec 12, 2023
1 check passed
@mar-v-in
Copy link
Member

Thanks for the patch @Uldiniad and for the explanation @t-m-w.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mar-v-in mar-v-in Awaiting requested review from mar-v-in

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uldiniad @t-m-w @mar-v-in