-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hide app icon
option
#2462
base: master
Are you sure you want to change the base?
Add Hide app icon
option
#2462
Conversation
Hide icon from launcher
optionHide app icon
option
85b2d24
to
39c349b
Compare
The icon should be enabled by default. These two should seems to do the opposite: |
Also in my opinion the variable name seems a bit strange: Personally I would choose |
The option in microG settings is disabled so the icon should be enabled by default, but you disable the icon in reality here:
Edit: Now that I read better, here you don't disable the icon but the MainSettingsActivity so you actually break the microG settings. This shouldn't be touched => org.microg.gms.ui.MainSettingsActivity |
play-services-base/core/src/main/kotlin/org/microg/gms/settings/SettingsProvider.kt
Outdated
Show resolved
Hide resolved
This is just personal opinion but in this case: instead with this: So actually it is the same in practice but I think the first is just more confusing but it is still personal preference. @mar-v-in What do you think? |
75e6627
to
6f4e97f
Compare
@mar-v-in & @ale5000-git, a gentle ping for review. |
Adds an option to hide icon from launcher.
Resolves #2263, resolves #2266 as well as resolves #2361.
Credits: @rufusin