-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vending build info initialization parameter is null #2571
base: master
Are you sure you want to change the base?
Fix vending build info initialization parameter is null #2571
Conversation
Shouldn't we rather make sure to never call Also, the current code doesn't assume the remote profile to be applied if the applied dataset is empty or an exception occurs while fetching it. So it's unclear to me how we can run into the issue you mention. Your current code also checks a random subset of profile fields to be unset. Why isn't a single one enough and why did you choose those and not others. The check seems a little fuzzy to me. |
You can try this APP |
I think "vending" should display an error and not initialize anything if microg services isn't installed as it isn't a supported configuration. |
If mg is not installed, the third-party APP will prompt. If we prompt again, it will be repeated and affect the user experience. |
We can (in my opinion):
|
Reproduction steps:
1.Install vending without installing mg
2.Find an APP to trigger IAP and trigger build info initialization
3.install mg
4.IAP problem found
The problem is that the build info of vending depends on mg. If mg is not installed, the parameters in the build are null. The build info is initialized only once, so it will not be initialized again after mg is installed, resulting in the parameters in the build being null all the time.