Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved readme #147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improved readme #147

wants to merge 3 commits into from

Conversation

ale5000-git
Copy link
Member

@ale5000-git ale5000-git commented Jan 6, 2018

Merged info for all Android versions to have a global idea
Make it usable when the device is inside the recovery or inside the system
Added separate adb commands for various Android versions
Added info for Oreo
Added Déjà Vu Location Service

(Based on pull request #146 by @David-Guillot)


This change is Reviewable

Merged info for all Android versions to have a global idea
Make it usable when the device is inside the recovery or inside the system
Added separate adb commands for various Android versions
Added info for Oreo
Added Déjà Vu Location Service

(Based on pull request microg#146 by @David-Guillot)
README.md Outdated

1. Make sure that no Google geolocation tool is installed (it is usually listed as Google Play Services in Apps)
2. Download and install `NetworkLocation.apk` as a usual app (you may need to enable "Unknown sources" in Settings->Security)
3. Reboot and continue at [Usage](#usage)

Some ROMs, especially those not based on AOSP might have problems using this method. However, if your system has root, you can try installing the hard way:
**Important:** Installing as system app will always works, instead installing as user app will only works out of the box on Android versions from 4.4 to 6.x.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "will only work out of the box" (minus the s)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

README.md Outdated
@@ -27,7 +27,7 @@ On these systems installation is easy:
2. Download and install `NetworkLocation.apk` as a usual app (you may need to enable "Unknown sources" in Settings->Security)
3. Reboot and continue at [Usage](#usage)

**Important:** Installing as system app will always works, instead installing as user app will only works out of the box on Android versions from 4.4 to 6.x.
**Important:** Installing as system app will always works, instead installing as user app will only work out of the box on Android versions from 4.4 to 6.x.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly improve grammar:

Installing as a system app will always work for all versions of Android. But installing as user app will only work on Android versions 4.4 to 6.x.

Copy link
Member Author

@ale5000-git ale5000-git Jan 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept "out of the box" because it means without changes, you can make it working (but not out of the box).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also strike the "s" in "will always works" (→ "will always work") :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already corrected it when I have talked about "out of the box".

@IzzySoft
Copy link

IzzySoft commented Jan 8, 2018

Looks like you have trouble with the "s". Shouldn't it read

Installing as system app will always works

And instead

I have kept "out of the box" because it means without changes …

? 😉

@ale5000-git
Copy link
Member Author

ale5000-git commented Jan 9, 2018

@IzzySoft: Fixed, see reply here.

@ilpianista ilpianista mentioned this pull request Sep 25, 2020
@@ -54,6 +80,7 @@ Here is a list of backends known to me.

List of backends for geolocation:
* [AppleWifiNlpBackend](https://github.com/microg/AppleWifiNlpBackend) - Uses Apple's service to resolve Wi-Fi locations. It has excellent coverage but the database is proprietary.
* [Déjà Vu](https://github.com/n76/DejaVu) - A backend that uses locally acquired WLAN/WiFi AP and mobile/cellular tower data to resolve user location.
Copy link

@DJCrashdummy DJCrashdummy Jul 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW: instead of the whole section, linking to https://github.com/microg/UnifiedNlp/wiki/Backends would be easier (and is more up-to-date).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants