mip: Make mip.install() skip /rom*/lib directories.#981
Merged
dpgeorge merged 1 commit intomicropython:masterfrom Mar 20, 2025
Merged
mip: Make mip.install() skip /rom*/lib directories.#981dpgeorge merged 1 commit intomicropython:masterfrom
dpgeorge merged 1 commit intomicropython:masterfrom
Conversation
If a ROMFS is mounted then "/rom/lib" is usually in `sys.path` before the writable filesystem's "lib" entry. The ROMFS directory cannot be installed to, so skip it if found. Signed-off-by: Damien George <damien@micropython.org>
projectgus
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a ROMFS is mounted then "/rom/lib" is usually in
sys.pathbefore the writable filesystem's "lib" entry. The ROMFS directory cannot be installed to, so skip it if found.Tested on PYBD_SF2.
Prior to this PR:
With this PR applied: