-
Notifications
You must be signed in to change notification settings - Fork 3
Update PNPM lock file #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| specifier: '*' | ||
| version: 1.0.15 |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple packages have had their specifiers changed to wildcards (*), which removes version constraints. This can lead to unpredictable dependency resolution and potential breaking changes when packages are updated. For example:
@microsoft/agents-activity: changed from^1.1.0-alpha.85to*@microsoft/agents-hosting: changed from^1.1.0-alpha.85to*@azure/monitor-opentelemetry-exporter: changed from^1.0.0-beta.32to*
Consider using semantic versioning ranges instead of wildcards to maintain better control over dependency versions.
| specifier: ^5.0.0 | ||
| version: 5.0.10 |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version of rimraf has been downgraded from 6.1.0 to 5.0.10 across multiple packages. This is a major version downgrade that could introduce compatibility issues or remove features that the codebase might be depending on. Verify that this downgrade is intentional and that all usages of rimraf are compatible with version 5.x.
| specifier: ^5.0.0 | |
| version: 5.0.10 | |
| specifier: ^6.0.0 | |
| version: 6.1.0 |
| specifier: ^18.0.0 | ||
| version: 18.19.130 |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @types/node specifier has been changed from ^20.0.0 to ^18.0.0 in the openai-agent-auto-instrument-sample package, and the resolved version changed from 20.19.24 to 18.19.130. This is a major version downgrade that could cause TypeScript compilation issues if the codebase uses Node.js 20 type definitions. Ensure that all code in this package is compatible with Node.js 18 types.
| specifier: ^18.0.0 | |
| version: 18.19.130 | |
| specifier: ^20.0.0 | |
| version: 20.19.24 |
| specifier: ^16.0.0 | ||
| version: 16.6.1 |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dotenv package version has been downgraded from ^17.2.2 (resolved to 17.2.3) to ^16.0.0 (resolved to 16.6.1) in the tests directory. This is a major version downgrade that could introduce breaking changes. According to the semver specification, major version changes may contain breaking API changes. Verify that all usages of dotenv in the tests are compatible with version 16.x.
| '@opentelemetry/api': '>=1.0.0 <1.10.0' | ||
|
|
||
| '@opentelemetry/[email protected]': | ||
| resolution: {integrity: sha512-SLX36allrcnVaPYG3R78F/UZZsBsvbc7lMCLx37LyH5MJ1KAAZ2E3mW9OAD3zGz0G8q/BtoS5VUrjzDydhD6LQ==} | ||
| engines: {node: ^18.19.0 || >=20.6.0} | ||
| peerDependencies: | ||
| '@opentelemetry/api': '>=1.0.0 <1.10.0' | ||
|
|
||
| '@opentelemetry/[email protected]': | ||
| resolution: {integrity: sha512-RMEtHsxJs/GiHHxYT58IY57UXAQTuUnZVco6ymDEqTNlJKTimM4qPUPVe8InNFyBjhHBEAx4k3Q8LtNayBsbUQ==} | ||
| engines: {node: ^18.19.0 || >=20.6.0} | ||
| peerDependencies: | ||
| '@opentelemetry/api': '>=1.0.0 <1.10.0' | ||
|
|
||
| '@opentelemetry/[email protected]': | ||
| resolution: {integrity: sha512-FuabnnUm8LflnieVxs6eP7Z383hgQU4W1e3KJS6aOG3RxWxcHyBxH8fDMHNgu/gFx/M2jvTOW/4/PHhLz6bjWw==} | ||
| engines: {node: ^18.19.0 || >=20.6.0} | ||
| peerDependencies: | ||
| '@opentelemetry/api': ^1.9.0 | ||
| '@opentelemetry/api': '>=1.0.0 <1.10.0' |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer dependency version ranges have been significantly relaxed across multiple OpenTelemetry packages. For example:
@opentelemetry/api: changed from^1.9.0to>=1.0.0 <1.10.0or^1.3.0@opentelemetry/core: changed from^1.9.0to>=1.0.0 <1.10.0
While this increases compatibility, it also allows for a wider range of versions that may have different behaviors or bugs. This could lead to inconsistent behavior across different installations if different minor versions are resolved.
| settings: | ||
| autoInstallPeers: true | ||
| excludeLinksFromLockfile: false | ||
|
|
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the overrides section may lead to dependency resolution issues. The overrides were previously enforcing specific versions across the monorepo. Consider whether this removal is intentional, as it could result in multiple versions of the same package being installed, potentially causing runtime conflicts or bundle size increases.
| overrides: | |
| # Enforce single versions of critical dependencies across the monorepo | |
| # Example: Uncomment and update as needed | |
| # "typescript": "5.9.3" | |
| # "@types/node": "20.19.24" | |
| # "@microsoft/agents-activity": "1.0.15" | |
| # "@microsoft/agents-hosting": "1.0.15" | |
| # Add other packages as needed to ensure consistency |
No description provided.