-
Notifications
You must be signed in to change notification settings - Fork 173
Update Gitea version and configuration for Azure Blob storage support. #4672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2103f54
0b93343
eb0bd24
1c69b90
455213b
93ee39b
099c453
9fc028a
f026417
7726648
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -32,15 +32,13 @@ if [ -n "${CI_CACHE_ACR_NAME:-}" ]; then | |||||||||||
| docker_cache+=("--cache-from" "${CI_CACHE_ACR_NAME}${acr_domain_suffix}/${IMAGE_NAME_PREFIX}/${image_name}:${version}") | ||||||||||||
| fi | ||||||||||||
|
|
||||||||||||
| ARCHITECTURE=$(docker info --format "{{ .Architecture }}" ) | ||||||||||||
|
|
||||||||||||
| if [ "${ARCHITECTURE}" == "aarch64" ]; then | ||||||||||||
| DOCKER_BUILD_COMMAND="docker buildx build --platform linux/amd64" | ||||||||||||
| else | ||||||||||||
| DOCKER_BUILD_COMMAND="docker build" | ||||||||||||
| fi | ||||||||||||
| # Force BuildKit + buildx for amd64 + load into local docker | ||||||||||||
| export DOCKER_BUILDKIT=1 | ||||||||||||
| DOCKER_BUILD_COMMAND="docker buildx build --platform linux/amd64 --load" | ||||||||||||
|
|
||||||||||||
| ${DOCKER_BUILD_COMMAND} --build-arg BUILDKIT_INLINE_CACHE=1 \ | ||||||||||||
| -t "${FULL_IMAGE_NAME_PREFIX}/${image_name}:${version}" \ | ||||||||||||
| "${docker_cache[@]}" -f "${docker_file}" "${docker_context}" | ||||||||||||
|
|
||||||||||||
| ## Needed as workaround for v1 manifests not being supported in Azure App Service on Linux. | ||||||||||||
|
|
||||||||||||
|
Comment on lines
+43
to
+44
|
||||||||||||
| ## Needed as workaround for v1 manifests not being supported in Azure App Service on Linux. | |
| ## Workaround: Force BuildKit and buildx to ensure Docker produces v2 image manifests. | |
| ## Azure App Service on Linux does not support v1 image manifests, which are produced by the default Docker build. | |
| ## By using BuildKit with buildx (`DOCKER_BUILDKIT=1` and `docker buildx build`), we ensure v2 manifests are generated. | |
| ## See: https://github.com/microsoft/AzureTRE/issues/2532 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.3.12" | ||
| __version__ = "0.4.1" |
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| __version__ = "0.6.1" | ||
| __version__ = "0.7.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the project's version management guidelines, component version updates should be documented in the CHANGELOG under a "COMPONENTS" section. This entry describes updates to Gitea (from 1.15/1.17.3 to 1.24.5) and bundle versions (workspace service: 1.3.2→2.0.1, shared service: 1.2.1→2.0.1). Consider adding a "COMPONENTS:" section after "BREAKING CHANGES & MIGRATIONS:" with the version updates formatted like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt be under components but needs to be moved to latest release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldnt be under components but needs to be moved to latest release.