-
Notifications
You must be signed in to change notification settings - Fork 285
PEPPOL 3.0 1P App #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Groenbech96
wants to merge
28
commits into
main
Choose a base branch
from
private/magnushar/PEPPOLIteration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
PEPPOL 3.0 1P App #5126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the PEPPOL 3.0 electronic document format to enable sending and receiving business documents according to the PEPPOL standard. This initial implementation includes: - Core codeunits for managing and validating PEPPOL documents - XMLports for exporting Sales Invoices and Credit Memos - New enums and interfaces to provide extensibility - Service support for handling Service Invoices and Credit Memos The implementation provides a framework for creating PEPPOL-compliant documents and ensures data integrity through validation rules.
Moves main app source files into an 'App' subfolder and introduces a new 'Test' folder for PEPPOL, including test runner configuration, logo, test app manifest, and an extensive automated test suite for PEPPOL functionality and validation. Enables comprehensive automated testing and separation of production and test code for improved maintainability.
Improves maintainability and developer experience by introducing comprehensive XML documentation across PEPPOL 3.0 management, validation, export, and interface layers. Summarizes intent, parameters, and return values for procedures, enums, and fields. Enhances clarity and discoverability of PEPPOL e-document processing, validation, and export workflows, supporting better onboarding and future extensibility.
Eliminates unused format provider references to simplify code and reduce maintenance overhead. Renames various procedures for consistency and clarity. Refactors tests to use interfaces instead of concrete implementations, enhancing flexibility and future extensibility.
Aligns codeunit and app object IDs with new reserved range to ensure compliance with updated extension conventions and prevent conflicts with existing objects.
Introduces examples and guidance for extending PEPPOL export functionality, including dependency setup, enum extensions, and interface implementations. Helps partners customize business logic and validation while leveraging standard procedures.
…ment.Codeunit.al Co-authored-by: Grasiele Matuleviciute <[email protected]>
…mentImpl.Codeunit.al Co-authored-by: Grasiele Matuleviciute <[email protected]>
…um.al Co-authored-by: Grasiele Matuleviciute <[email protected]>
…Impl.Codeunit.al Co-authored-by: Grasiele Matuleviciute <[email protected]>
Co-authored-by: Grasiele Matuleviciute <[email protected]>
…PPOL30Mgmt.Codeunit.al Co-authored-by: Grasiele Matuleviciute <[email protected]>
Co-authored-by: Grasiele Matuleviciute <[email protected]>
…e/BCApps into dev/aan/PEPPOL_App
Co-authored-by: Grasiele Matuleviciute <[email protected]>
…e/BCApps into dev/aan/PEPPOL_App
Integrates format provider selection via company setup, replacing hardcoded logic and manual interface instantiation. Improves extensibility for PEPPOL document export and related info providers. Reduces obsolete comments and unused code, clarifies interface documentation, and corrects minor typos. Enables easier support for future e-document formats and cleaner code maintenance.
Ensures new electronic document formats are automatically created when the app is installed by introducing a dedicated install codeunit and refactoring initialization logic. Updates documentation to clarify adjustments needed for PEPPOL format usage.
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @altotovi @Groenbech96
Implementation
Created new PEPPOL and Tests-PEPPOL apps to move PEPPOL BIS 3.0 format out of Base app to a 1P app. Replaced the extensibility points with interfaces instead of events.
This initial implementation includes:
Core codeunits for managing and validating PEPPOL documents
XMLports for exporting Sales Invoices and Credit Memos
New enums and interfaces to provide extensibility
Service support for handling Service Invoices and Credit Memos
The implementation provides a framework for creating PEPPOL-compliant documents and ensures data integrity through validation rules.
You can find new app extensibility examples in extensibility_examples.md file (part of this pull request)
Important
This Pull request related with https://github.com/microsoft/BusinessCentralApps/pull/1595
Fixes #