Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize deepspeed linear and implement it for non cuda systems #6932

Merged
merged 15 commits into from
Jan 29, 2025
Merged

generalize deepspeed linear and implement it for non cuda systems #6932

merged 15 commits into from
Jan 29, 2025

Conversation

oelayan7
Copy link
Contributor

@oelayan7 oelayan7 commented Jan 8, 2025

No description provided.

loadams
loadams reviewed Jan 8, 2025
View reviewed changes
op_builder/fp_quantizer.py Outdated Show resolved Hide resolved
@oelayan7
Copy link
Contributor Author

oelayan7 commented Jan 9, 2025

@loadams I think the failure in cpu-torch isn't related to the changes, as it passed yesterday (in the first commit)

Thanks in advance

@loadams
Copy link
Contributor

loadams commented Jan 9, 2025

@loadams I think the failure in cpu-torch isn't related to the changes, as it passed yesterday (in the first commit)

Thanks in advance

@oelayan7 - yes, I've not yet debugged this failure since it only occurs on some of the GitHub provided runners, but it is intermittent and I'll re-run.

@oelayan7
Copy link
Contributor Author

@loadams tests are passing now. Looks like it was a momentary issue

@oelayan7 oelayan7 requested a review from loadams January 16, 2025 06:39
@nelyahu
Copy link
Contributor

nelyahu commented Jan 26, 2025

@loadams Hi, can you please help review this PR? i see there was one round of review, are there any leftovers?

@loadams loadams requested a review from jeffra January 28, 2025 00:39
@loadams
Copy link
Contributor

loadams commented Jan 28, 2025

@loadams Hi, can you please help review this PR? i see there was one round of review, are there any leftovers?

Sorry for the delay @nelyahu and @oelayan7, working on getting the right set of eyes on this. We will prioritize it this week.

jeffra
jeffra requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, thanks for this generalization! However, please address @tjruwase's suggestions.

@oelayan7 oelayan7 requested review from jeffra and tjruwase January 28, 2025 12:55
@tjruwase
Copy link
Contributor

This all looks good to me, thanks for this generalization! However, please address @tjruwase's suggestions.

@jeffra, the merging seems to be blocked by your requested changes. How to unblock?

@loadams loadams added this pull request to the merge queue Jan 29, 2025
Merged via the queue into microsoft:master with commit 593de92 Jan 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@jeffra jeffra jeffra approved these changes

@tohtana tohtana Awaiting requested review from tohtana tohtana is a code owner

@jomayeri jomayeri Awaiting requested review from jomayeri jomayeri is a code owner

@loadams loadams Awaiting requested review from loadams loadams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oelayan7 @loadams @nelyahu @tjruwase @jeffra