feat: Refactor error handling and update parameter retrieval methods#120
Open
Saswato-Microsoft wants to merge 1 commit intomicrosoft:feat/addPostgreFabricMirrorfrom
Open
Conversation
…parameter retrieval methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several reliability and robustness improvements across deployment scripts and configuration files, with a focus on handling transient errors, improving workspace creation logic, and ensuring proper parameterization. The most significant changes include enhanced retry logic for Azure deployments, improved error handling for workspace creation, and connection timeout retries for OneLakeIndex scripts.
Deployment robustness improvements:
preprovision-integrated.ps1, including polling for account provisioning state, cleaning up failed deployments before retry, and limiting retries to three attempts. This helps handle transient errors such asAccountProvisioningStateInvalidand ensures deployments only fail after multiple attempts. [1] [2] [3]$env:TEMP,$env:TMPDIR, or/tmpas needed.Workspace creation error handling:
create_fabric_workspace.ps1to handle 409 Conflict errors by retrying workspace lookup via/workspacesand/groupsendpoints, ensuring existing workspaces are properly identified and reused. [1] [2]$pincipalId→$principalId) when assigning admin roles to workspaces, ensuring correct role assignment. [1] [2]Connection timeout handling for OneLakeIndex scripts:
02_create_onelake_skillsets.ps1,03_create_onelake_index.ps1,04_create_onelake_datasource.ps1,05_create_onelake_indexer.ps1), allowing the scripts to wait and retry when the search service data plane is not yet available. [1] [2] [3] [4]Parameterization and configuration fixes:
principalIdininfra/main.bicepparamto be read from theAZURE_PRINCIPAL_IDenvironment variable, improving flexibility and automation.fabricCapacityAdminsininfra/main.bicepparamto avoid empty array issues.azure.yamlto match the actual directory structure.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information