Try using UV for faster installs by hallipr · Pull Request #1112 · microsoft/GitHub-Copilot-for-Azure

hallipr · 2026-03-03T19:45:15Z

No description provided.

Copilot

Pull request overview

This PR switches the Azure benchmark pipeline from a preinstalled Python toolchain (UsePythonVersion) to using uv for installing Python and the msbench-cli, aiming to speed up dependency installs and support local runs with authenticated private-feed access.

Changes:

Add an Azure Pipelines step template to install uv across OSes.
Update the benchmark pipeline to install Python 3.12 via uv instead of UsePythonVersion.
Update the benchmark runner script to install/run msbench-cli via uv and add a local-feed-auth fallback using az.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
`pipelines/templates/steps/install-uv.yml`	Adds cross-platform `uv` installation steps for pipelines.
`pipelines/scripts/Invoke-CopilotBenchmarks.ps1`	Switches `msbench-cli` install/run to `uv` and adds local feed auth fallback.
`pipelines/azure-benchmarks.yml`	Replaces `UsePythonVersion@0` with `uv` install + `uv python install 3.12`.

pipelines/templates/steps/install-uv.yml

pipelines/azure-benchmarks.yml

Copilot · 2026-03-03T19:50:29Z

pipelines/scripts/Invoke-CopilotBenchmarks.ps1

-    python -m pip install msbench-cli --no-input
+    uv pip install msbench-cli --no-input
    if ($LASTEXITCODE -ne 0) {
        throw "pip install msbench-cli failed with exit code $LASTEXITCODE"


The failure message still says pip install msbench-cli failed..., but the command is now uv pip install .... This makes debugging harder because logs will reference the wrong tool; update the error text to match the actual command being executed.

Suggested change

throw "pip install msbench-cli failed with exit code $LASTEXITCODE"

throw "uv pip install msbench-cli failed with exit code $LASTEXITCODE"

pipelines/scripts/Invoke-CopilotBenchmarks.ps1

pipelines/templates/steps/install-uv.yml

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

pipelines/templates/steps/install-uv.yml

pipelines/azure-benchmarks.yml

pipelines/scripts/Invoke-CopilotBenchmarks.ps1

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

pipelines/scripts/Invoke-CopilotBenchmarks.ps1

Copilot · 2026-03-03T22:35:03Z

pipelines/azure-benchmarks.yml

+    - template: /pipelines/templates/steps/install-uv.yml
+
+    - pwsh: uv python install 3.12
+      displayName: 'Install Python 3.12 with uv'


uv python install 3.12 installs a Python runtime, but nothing here ensures subsequent uv pip/uv run commands will actually use 3.12 (and UsePythonVersion@0 was removed). Consider explicitly selecting the interpreter (e.g., passing --python 3.12 to the uv commands or setting the appropriate env var) so the benchmark runs against the intended Python version.

pipelines/azure-benchmarks.yml

pipelines/templates/steps/install-uv.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.

Copilot · 2026-03-03T23:05:26Z

pipelines/scripts/Create-Venv.ps1

+    [string] $VenvName = "venv"
+)
+
+$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve


The help text documents a RepoRoot parameter, but the script only accepts VenvName. This mismatch is also what causes callers to pass -RepoRoot and fail. Either add a RepoRoot parameter (and honor it when building $venvPath) or remove the RepoRoot documentation.

Suggested change

[string] $VenvName = "venv"

)

$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve

[string] $VenvName = "venv",

[string] $RepoRoot

)

if ($PSBoundParameters.ContainsKey('RepoRoot') -and $RepoRoot) {

$repoRoot = $RepoRoot

}

else {

$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve

}

Copilot · 2026-03-03T23:05:27Z

pipelines/scripts/Activate-Venv.ps1

+    exit 1
+}
+
+Write-Host "Activating virtual environment '$VenvName' via VIRTUAL_ENV variable at $venvPath.'"


Log message has an extra trailing apostrophe after the venv path (... at $venvPath.'). This looks like a typo and can be confusing when reading pipeline logs.

Suggested change

Write-Host "Activating virtual environment '$VenvName' via VIRTUAL_ENV variable at $venvPath.'"

Write-Host "Activating virtual environment '$VenvName' via VIRTUAL_ENV variable at $venvPath."

Copilot · 2026-03-03T23:05:27Z

pipelines/scripts/Create-Venv.ps1

+if (!(Test-Path $venvPath)) {
+    if (Get-Command uv -ErrorAction SilentlyContinue) {
+        Write-Host "Creating virtual environment '$VenvName' using uv."
+        uv venv $venvPath  --verbose
+    }
+    else {
+        $invokingPython = (Get-Command "python").Source
+
+        Write-Host "Creating virtual environment '$VenvName' using virtualenv and python located at '$invokingPython'."
+        python -m pip install virtualenv==20.25.1
+        python -m virtualenv $venvPath
+    }


Native command failures in this script aren’t checked. uv venv, python -m pip install ..., and python -m virtualenv ... can fail without throwing, and the script will continue (PowerShell doesn’t automatically stop on non-zero exit codes from native commands). Consider checking $LASTEXITCODE/$? after each native command and throwing on failure to avoid silently continuing with a missing/broken venv.

Copilot · 2026-03-03T23:05:27Z

pipelines/scripts/Create-Venv.ps1

+        python -m pip install virtualenv==20.25.1
+        python -m virtualenv $venvPath
+    }
+    $pythonVersion = python --version


$pythonVersion = python --version will report the invoking shell’s python, not necessarily the interpreter used to create the venv (especially in the uv venv path). If the intent is to log the venv’s Python version, query the venv interpreter directly (e.g., $venvPath/bin/python or $venvPath/Scripts/python.exe).

Suggested change

$pythonVersion = python --version

if ($IsWindows) {

$venvPython = Join-Path $venvPath "Scripts/python.exe"

}

else {

$venvPython = Join-Path $venvPath "bin/python"

}

$pythonVersion = & $venvPython --version

Copilot · 2026-03-03T23:05:27Z

pipelines/scripts/Invoke-CopilotBenchmarks.ps1

+. "$PSScriptRoot/Create-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot
+. "$PSScriptRoot/Activate-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot


The dot-sourced venv scripts are invoked with -RepoRoot $repoRoot, but neither Create-Venv.ps1 nor Activate-Venv.ps1 defines a RepoRoot parameter. This will fail with “A parameter cannot be found…” before the benchmark runs. Either add a [string]$RepoRoot param to both scripts (and use it instead of recomputing $repoRoot), or remove -RepoRoot from these calls.

Suggested change

. "$PSScriptRoot/Create-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot

. "$PSScriptRoot/Activate-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot

. "$PSScriptRoot/Create-Venv.ps1" -VenvName "venv"

. "$PSScriptRoot/Activate-Venv.ps1" -VenvName "venv"

Copilot · 2026-03-03T23:05:28Z

pipelines/scripts/Activate-Venv.ps1

+    [string]$VenvName = "venv"
+)
+
+Set-StrictMode -Version 4
+$ErrorActionPreference = "Stop"
+
+$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve


The help text documents a RepoRoot parameter, but the script only accepts VenvName. Since this script is dot-sourced by the benchmark runner, callers passing -RepoRoot will error. Add a RepoRoot parameter (and use it for $venvPath) or remove the RepoRoot documentation and update callers accordingly.

Suggested change

[string]$VenvName = "venv"

)

Set-StrictMode -Version 4

$ErrorActionPreference = "Stop"

$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve

[string]$VenvName = "venv",

[string]$RepoRoot

)

Set-StrictMode -Version 4

$ErrorActionPreference = "Stop"

if ($RepoRoot) {

$repoRoot = $RepoRoot

} else {

$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve

}

Copilot · 2026-03-03T23:05:28Z

pipelines/scripts/Activate-Venv.ps1

+
+if (-not (Test-Path $venvPath)) {
+    Write-Error "Virtual environment '$venvPath' does not exist at $venvPath"
+    exit 1


Because this script is intended to be dot-sourced, calling exit 1 will terminate the entire PowerShell session immediately, which makes it hard for the caller to handle/report errors consistently. Prefer throw here so the calling script can fail naturally (and optionally catch/log) while still stopping execution.

Suggested change

exit 1

throw

hallipr · 2026-03-05T22:42:38Z

@copilot, can you iterate on this until it can install and run via UV?

Copilot · 2026-03-05T22:42:45Z

@hallipr I've opened a new pull request, #1148, to work on those changes. Once the pull request is ready, I'll request review from you.

JasonYeMSFT · 2026-03-11T18:19:33Z

@hallipr Do you still want to merge this PR?

Try using UV for faster installs

d7de256

Copilot AI review requested due to automatic review settings March 3, 2026 19:45

Copilot started reviewing on behalf of hallipr March 3, 2026 19:45 View session

hallipr added this to Azure MCP Server Mar 3, 2026

github-project-automation bot moved this to Untriaged in Azure MCP Server Mar 3, 2026

hallipr moved this from Untriaged to In Progress in Azure MCP Server Mar 3, 2026

Copilot AI reviewed Mar 3, 2026

View reviewed changes

hallipr added 2 commits March 3, 2026 11:58

Fix uv install command args

bfaceed

Allow ci to uv pip install --system

aa122e2

Copilot AI review requested due to automatic review settings March 3, 2026 22:05

Copilot started reviewing on behalf of hallipr March 3, 2026 22:05 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

pipelines/templates/steps/install-uv.yml Show resolved Hide resolved

pipelines/templates/steps/install-uv.yml Show resolved Hide resolved

pipelines/azure-benchmarks.yml Outdated Show resolved Hide resolved

pipelines/scripts/Invoke-CopilotBenchmarks.ps1 Outdated Show resolved Hide resolved

Just pass the extra args from ci

72c62db

Copilot AI review requested due to automatic review settings March 3, 2026 22:28

hallipr force-pushed the users/pahallis/run-bench branch from ec75ecf to 72c62db Compare March 3, 2026 22:28

Copilot started reviewing on behalf of hallipr March 3, 2026 22:29 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

hallipr and others added 2 commits March 3, 2026 14:58

Improve venv handling

b2626f6

Update pipelines/azure-benchmarks.yml

921bb1e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 3, 2026 23:00

Copilot started reviewing on behalf of hallipr March 3, 2026 23:01 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Copilot AI mentioned this pull request Mar 5, 2026

Fix UV benchmark pipeline: Linux PATH, venv dot-source params, and install pattern #1148

Draft

This was referenced Mar 6, 2026

[repo-status] Weekly Repo Status — Feb 27 – Mar 6, 2026 #1154

Open

[repo-status] Weekly Repo Status — Feb 27 – Mar 6, 2026 #1173

Open

	throw "pip install msbench-cli failed with exit code $LASTEXITCODE"
	throw "uv pip install msbench-cli failed with exit code $LASTEXITCODE"

-    [string] $VenvName = "venv"
-)
-$repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve
+    [string] $VenvName = "venv",
+    [string] $RepoRoot
+)
+if ($PSBoundParameters.ContainsKey('RepoRoot') -and $RepoRoot) {
+    $repoRoot = $RepoRoot
+}
+else {
+    $repoRoot = Join-Path $PSScriptRoot ".." ".." -Resolve
+}

	Write-Host "Activating virtual environment '$VenvName' via VIRTUAL_ENV variable at $venvPath.'"
	Write-Host "Activating virtual environment '$VenvName' via VIRTUAL_ENV variable at $venvPath."

-    $pythonVersion = python --version
+    if ($IsWindows) {
+        $venvPython = Join-Path $venvPath "Scripts/python.exe"
+    }
+    else {
+        $venvPython = Join-Path $venvPath "bin/python"
+    }
+    $pythonVersion = & $venvPython --version

		. "$PSScriptRoot/Create-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot
		. "$PSScriptRoot/Activate-Venv.ps1" -VenvName "venv" -RepoRoot $repoRoot

Conversation

hallipr commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

hallipr commented Mar 5, 2026

Uh oh!

Copilot AI commented Mar 5, 2026

Uh oh!

JasonYeMSFT commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants