Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign samples #254

Merged
merged 8 commits into from
Jan 29, 2025
Merged

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jan 14, 2025

Related PR: MicrosoftDocs/edge-developer#3342

This PR makes the following changes:

Retested samples after all changes.

AB#55806358

@mikehoffms mikehoffms marked this pull request as ready for review January 15, 2025 23:04
Copy link

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosjeurissen
Copy link

@mikehoffms I would suggest to use document.head and document.body instead of the document.querySelector equivalent.

@mikehoffms
Copy link
Contributor Author

mikehoffms commented Jan 16, 2025

@carlosjeurissen - latest commits moved away from document.querySelector. Updated topmost comment of PR.
0 hits in repo branch on "querySelector".
FTS in repo branch for document. --
image
Tested the code changes & dir name changes.

Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Content Developer

Copy link

@yvsubhash yvsubhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -Dev

@sivMSFT sivMSFT merged commit f20fc9b into microsoft:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants