-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign samples #254
Redesign samples #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mikehoffms I would suggest to use |
@carlosjeurissen - latest commits moved away from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Content Developer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -Dev
Related PR: MicrosoftDocs/edge-developer#3342
This PR makes the following changes:
README.md
/Extension-samples/
directory/picture-viewer-popup-webpage/
dir/extension-getting-started-part1/
.nasapod16x16.png
toextension-icon16x16.png
./picture-inserter-content-script/
dir/extension-getting-started-part2/
.document.
./lib/
dir & itsjquery.min.js
file.guidGenerator
function &Math.random
calls with a single call ofcrypto.randomUUID()
.nasapod16x16.png
toextension-icon16x16.png
.Sample extensions
empty filetest
empty fileRetested samples after all changes.
AB#55806358