ci: switches to public API analyzer #2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Convert PublicApi.approved.txt to PublicApiAnalyzers format - Converted test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt (2152 lines) to src/Microsoft.OpenApi/PublicAPI.Shipped.txt (1844 entries) - Generated PublicAPI.Shipped.txt and PublicAPI.Unshipped.txt files for both Microsoft.OpenApi and Microsoft.OpenApi.YamlReader projects - Added Microsoft.CodeAnalysis.PublicApiAnalyzers package reference in Directory.Build.props The conversion extracted 1843 public API declarations from the PublicApiGenerator format and converted them to the Microsoft.CodeAnalysis.PublicApiAnalyzers format: - Types (classes, interfaces, structs, enums, delegates) - Constructors - Methods - Properties (with get/set accessors) - Fields (including const fields) - Events - Enum values with their numeric assignments Note: Build validation and potential missing API entries will need to be addressed in follow-up work as the PublicApiAnalyzers may identify additional public APIs not captured in the original PublicApiGenerator output. * Populate PublicAPI.Shipped.txt for Microsoft.OpenApi project Co-authored-by: baywet <[email protected]> * Remove backup files * Fix PublicAPI.Unshipped.txt for Microsoft.OpenApi.YamlReader - Generated public API using PublicApiGenerator for Microsoft.OpenApi.YamlReader assembly - Converted to PublicApiAnalyzers format and added to PublicAPI.Unshipped.txt - Made static ReadFragment<T>(JsonNode...) method internal to resolve RS0016 and RS0026 analyzer errors - Resolved RS0016/RS0017 analyzer errors for YamlReader project - Note: RS0036 nullability annotation warnings remain but are separate from PublicAPI format issues Co-authored-by: baywet <[email protected]> * chore: removes old unit test based public API validation Signed-off-by: Vincent Biret <[email protected]> * chore: reverts copilot hallucination Signed-off-by: Vincent Biret <[email protected]> * chore: moves the analyzer to library projects only * chore: refreshes API export Signed-off-by: Vincent Biret <[email protected]> --------- Signed-off-by: Vincent Biret <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: baywet <[email protected]> Co-authored-by: Vincent Biret <[email protected]>
|
adrian05-ms
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reflection of #2711 in v2