[PTRun][Calc]Add list separator handling for different cultures

microsoft · Jan 7, 2025 · 6441fec · 6441fec
1 parent 809791d
commit 6441fec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...ncher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest/NumberTranslatorTests.cs b/...ncher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator.UnitTest/NumberTranslatorTests.cs
@@ -74,6 +74,7 @@ public void Translate_WhenCalledEmpty(string input)
         [DataRow("5,2+6", "5.2+6")]
         [DataRow("round(2,5)", "round(2.5)")]
         [DataRow("3,3333", "3.3333")]
+        [DataRow("max(2;3)", "max(2,3)")]
         public void Translate_NoErrors_WhenCalled(string input, string expectedResult)
         {
             // Arrange

diff --git a/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/NumberTranslator.cs b/src/modules/launcher/Plugins/Microsoft.PowerToys.Run.Plugin.Calculator/NumberTranslator.cs
@@ -123,7 +123,7 @@ private static string Translate(string input, CultureInfo cultureFrom, CultureIn
                     outputBuilder.Append(
                         decimal.TryParse(token, NumberStyles.Number, cultureFrom, out number)
                         ? (new string('0', leadingZeroCount) + number.ToString(cultureTo))
-                        : token);
+                        : token.Replace(cultureFrom.TextInfo.ListSeparator, cultureTo.TextInfo.ListSeparator));
                 }
             }