Skip to content

Test coverage for search_n with impossible value #5440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexGuteniev
Copy link
Contributor

Thanks for adding some imposible coverage to vector algorithms, @StephanTLavavej!

But you seem to miss the one you've then-recently reviewed 😹

I had to damage the sequence in the test array a bit, because for search_n coverage to properly cover the right branch, we need to search for more than one consecutive element, otherwise we get special n=1 case.

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 26, 2025 06:02
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Apr 26, 2025
@StephanTLavavej StephanTLavavej self-assigned this Apr 26, 2025
@StephanTLavavej StephanTLavavej added the test Related to test code label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
Status: Initial Review
Development

Successfully merging this pull request may close these issues.

2 participants