Skip to content

Conversation

@Sun-Jc
Copy link
Contributor

@Sun-Jc Sun-Jc commented Oct 28, 2025

@Sun-Jc Sun-Jc marked this pull request as ready for review October 28, 2025 03:48
@srinathsetty srinathsetty requested a review from Copilot October 28, 2025 23:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the sum-check protocol to optimize the handling of the power-of-tau polynomial by splitting it into an outer product representation of two smaller polynomials. This reduces memory usage and improves performance by avoiding the explicit computation of the full tensor product.

Key changes:

  • Splits the power-of-tau polynomial into left and right components for efficient outer product computation
  • Adds a new optimized evaluation function that computes cubic polynomial evaluation points using the split representation
  • Converts split_evals from an instance method to a static method to avoid unnecessary object construction

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/sumcheck.rs Fixes bug in length calculation (line 362), adds new compute_eval_points_cubic_with_additive_term_with_outer_pow function for optimized evaluation with split tau polynomials, and updates prove_cubic_with_additive_term_batched_zk to use split polynomial representation
src/polys/power.rs Refactors split_evals from instance method to static method, removing dependency on self
src/neutronnova_zk.rs Updates tau polynomial construction to use split representation and passes split components to sum-check proving function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@srinathsetty srinathsetty merged commit 3075b51 into microsoft:main Nov 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants