Skip to content

Allow path-filters to continue on error. #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/build-docker-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@ permissions:

jobs:
deploy:
environment: development-fork
environment: development-fork
runs-on: ubuntu-latest # pnpm deploy does not work currently on Windows. Fails with EPERM.

steps:

- name: Setup Git LF
run: |
git config --global core.autocrlf false
Expand All @@ -31,33 +30,37 @@ jobs:

- uses: dorny/paths-filter@v3
id: filter
continue-on-error: true
with:
filters: |
ts:
- "ts/**"
- ".github/workflows/build-ts.yml"

- uses: pnpm/action-setup@v4
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
name: Install pnpm
with:
package_json_file: ts/package.json

- uses: actions/setup-node@v4
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
with:
node-version: ${{ matrix.version }}
#cache: "pnpm"
#cache-dependency-path: ts/pnpm-lock.yaml

- name: Login to Azure
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
uses: azure/[email protected]
with:
client-id: ${{ secrets.AZUREAPPSERVICE_CLIENTID_5B0D2D6BA40F4710B45721D2112356DD }}
tenant-id: ${{ secrets.AZUREAPPSERVICE_TENANTID_39BB903136F14B6EAD8F53A8AB78E3AA }}
subscription-id: ${{ secrets.AZUREAPPSERVICE_SUBSCRIPTIONID_F36C1F2C4B2C49CA8DD5C52FAB98FA30 }}

- name: Set up Docker Buildx
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
uses: docker/setup-buildx-action@v3

- run: az acr build -t typeagent:latest -r typeagentContainerRegistry --file ${{ github.workspace }}/ts/Dockerfile --subscription ${{ secrets.AZUREAPPSERVICE_SUBSCRIPTIONID_F36C1F2C4B2C49CA8DD5C52FAB98FA30 }} ${{ github.workspace }}/ts
- if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
run: az acr build -t typeagent:latest -r typeagentContainerRegistry --file ${{ github.workspace }}/ts/Dockerfile --subscription ${{ secrets.AZUREAPPSERVICE_SUBSCRIPTIONID_F36C1F2C4B2C49CA8DD5C52FAB98FA30 }} ${{ github.workspace }}/ts
9 changes: 5 additions & 4 deletions .github/workflows/build-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,24 @@ jobs:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
continue-on-error: true
with:
filters: |
dotnet:
- "dotnet/**"
- ".github/workflows/build-dotnet.yml"
- name: Setup MSBuild
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet != 'false' }}
uses: microsoft/setup-msbuild@v2
- name: Setup NuGet
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet != 'false' }}
uses: NuGet/[email protected]
- name: Restore Packages
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet != 'false' }}
working-directory: dotnet
run: nuget restore autoShell/AutoShell.sln
- name: Build Solution
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.dotnet != 'false' }}
working-directory: dotnet
run: |
msbuild.exe autoShell/AutoShell.sln /p:platform="Any CPU" /p:configuration="${{ matrix.configuration }}"
13 changes: 7 additions & 6 deletions .github/workflows/build-ts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,39 +45,40 @@ jobs:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
continue-on-error: true
with:
filters: |
ts:
- "ts/**"
- ".github/workflows/build-ts.yml"
- uses: pnpm/action-setup@v4
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
name: Install pnpm
with:
package_json_file: ts/package.json
- uses: actions/setup-node@v4
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
with:
node-version: ${{ matrix.version }}
cache: "pnpm"
cache-dependency-path: ts/pnpm-lock.yaml
- name: Install dependencies
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
working-directory: ts
run: |
pnpm install --frozen-lockfile --strict-peer-dependencies
- name: Build
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
working-directory: ts
run: |
npm run build
- name: Test
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
working-directory: ts
run: |
npm run test:local
- name: Lint
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts == 'true' }}
if: ${{ github.event_name != 'pull_request' || steps.filter.outputs.ts != 'false' }}
working-directory: ts
run: |
npm run lint
3 changes: 2 additions & 1 deletion .github/workflows/shell-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:

- uses: dorny/paths-filter@v3
id: filter
continue-on-error: true
with:
filters: |
ts:
Expand Down Expand Up @@ -130,4 +131,4 @@ jobs:
run: |
rm ./.env
working-directory: ts
if: always()
if: always()
1 change: 1 addition & 0 deletions .github/workflows/smoke-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:

- uses: dorny/paths-filter@v3
id: filter
continue-on-error: true
with:
filters: |
ts:
Expand Down
Loading