Update core dependencies #1656
Closed
Update core dependencies #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
update-core-deps
branch
from
71b679c to
e817aec
Compare
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
| @@ -39,7 +39,7 @@ interface MessageEventInit<T = any> extends EventInit { | |||
| } | |||
|
|
|||
| interface PromiseRejectionEventInit extends EventInit { | |||
| promise: Promise<any>; | |||
| promise: any; | |||
There was a problem hiding this comment.
This is fishy. I did not found a corresponding change in BCD...
There was a problem hiding this comment.
This is only IDL-side change just to skip JS-to-IDL conversion steps, from TS side we should ignore this. See whatwg/html#9897.
typescript-bot
force-pushed
the
update-core-deps
branch
from
e817aec to
68d8661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action