fix: make TextEncoder.prototype.encode return Uint8Array<ArrayBuffer>
#1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
dsherret
commented
Jan 31, 2025
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/TextEncoder/encode) | ||
| */ | ||
| encode(input?: string): Uint8Array; | ||
| encode(input?: string): Uint8Array<ArrayBuffer>; |
There was a problem hiding this comment.
This is wrong for TS 5.5. The minimum should be TS 5.7. How do I deal with this?
|
The vast majority of web API parameters should use And yeah, it seems we need another set of versioned libs. Not sure we want to keep adding more and more versions though, @sandersn? |
|
superseded by #1944 |
|
Closing in favour of #1944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's surprising that this repo has zero references to
Uint8Array<ArrayBuffer>given how disruptive the change is for typed arrays.For microsoft/TypeScript#60846