Refactor test script for improved readability and modularity #1956
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Sure |
|
Done @saschanaz |
src/test.ts
Outdated
| function normalizeLineEndings(text: string): string { | ||
| return text.replace(/\r\n?/g, "\n"); | ||
| function normalizeLineEndings(text: string) { | ||
| text.replace(/\r\n?/g, "\n"); |
src/test.ts
Outdated
| try { | ||
| outputFiles = fs.readdirSync(outputFolder); | ||
| return normalizeLineEndings(fs.readFileSync(filePath, "utf-8")); |
There was a problem hiding this comment.
We already stat the file before calling this and thus doesn't expect any error here. Thus we should skip try-catch here to see actual failures if happens.
src/test.ts
Outdated
| const childBaselineFolder = new URL(`${file}/`, baselineFolder); | ||
| const childOutputFolder = new URL(`${file}/`, outputFolder); | ||
| if (!compareToBaselines(childBaselineFolder, childOutputFolder)) { | ||
| if (fs.existsSync(baselinePath) || fs.existsSync(outputPath)) { |
There was a problem hiding this comment.
This is not same as detecting directory?
src/test.ts
Outdated
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| function compileGeneratedFiles(lib: string, ...files: string[]) { | ||
| function compileGeneratedFiles(lib: string[] | string, ...files: string[]) { |
There was a problem hiding this comment.
But is lib ever an array here?
src/test.ts
Outdated
| console.error(e.stdout.toString()); | ||
| console.error(); |
There was a problem hiding this comment.
Skipping this would hide the actual error which would make debugging harder.
|
I have fixed them @saschanaz |
|
Hello @saschanaz |
This PR refactors the test script to enhance maintainability, readability, and efficiency.
Changes:
getFiles,readFileContent) to reduce redundancy.compileSetsarray to streamline and organize compilation tasks dynamically.Benefits: