Skip to content

Improve URLSearchParams constructor type definition #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve URLSearchParams constructor type definition #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8c8241
fix: improve URLSearchParams constructor type
rossrobino Jul 16, 2025
8f65345
fix: remove URLSearchParams from overrideType in init parameter
rossrobino Jul 16, 2025
bfdab3e
generate
rossrobino Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion baselines/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33187,7 +33187,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7794,7 +7794,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7337,7 +7337,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33164,7 +33164,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7794,7 +7794,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7337,7 +7337,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.5/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8943,7 +8943,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/audioworklet.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,7 +1396,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33187,7 +33187,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/serviceworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7794,7 +7794,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/sharedworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7337,7 +7337,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/ts5.6/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8943,7 +8943,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
2 changes: 1 addition & 1 deletion baselines/webworker.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8943,7 +8943,7 @@ interface URLSearchParams {

declare var URLSearchParams: {
prototype: URLSearchParams;
new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
new(init?: string | Iterable<[string, string]> | Record<string, string>): URLSearchParams;
};

/**
Expand Down
15 changes: 0 additions & 15 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,21 +647,6 @@
]
}
},
"URLSearchParams": {
"name": "URLSearchParams",
"constructor": {
"signature": {
"0": {
"param": [
{
"name": "init",
"additionalTypes": ["URLSearchParams"]
}
]
}
}
}
},
"NodeListOf": {
"name": "NodeListOf",
"typeParameters": [
Expand Down
17 changes: 16 additions & 1 deletion inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3842,7 +3842,22 @@
}
}
}
}
},
"URLSearchParams": {
"name": "URLSearchParams",
"constructor": {
"signature": {
"0": {
"param": [
{
"name": "init",
"overrideType": "string | Iterable<[string, string]> | Record<string, string>"
}
]
}
}
}
}
}
},
"dictionaries": {
Expand Down
Loading