-
Notifications
You must be signed in to change notification settings - Fork 446
Migrate to Typescript-go #2104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate to Typescript-go #2104
Conversation
Seems the answer is "not yet" |
First the problem is to fix this repo's imports; the repo is still using the old deprecated |
(I want my maintainer permission to push to this PR and see how it goes 🙈) |
Also, you definitely do not want to accept this PR as is, the native preview is just a preview and should not "replace" tsc at the time being. A new workflow to check it seems fine. |
Me too but I haven't gotten that settled yet |
The build error should be fixed when the next version of BCD is published |
I have updated it to use the latest bcd and typescript syntax @jakebailey |
It's using a jsconfig and then looking into the JS types for the package instead of the dts file, which is interesting. I'm not sure any of us have actually tested jsconfig. Worth a bug and a more minimal repro. |
Oh, the types for semver aren't even installed in the repo. Yeah, I think this might be expected. |
I will create a minimal repro and open an issue today. |
Why did we go ahead to fix BCD instead of investigating why tsgo fails on BCD even though ts5 is okay with it? |
I think this answers your question @saschanaz |
But this PR doesn't use node10 anymore? |
We didn't implement node10 in tsgo; right now it silently maps itself to bundler resolution for easier testing, but will error in the future. The errors shown in this PR (before the dep fixes) would appear with tsc in newer resolution modes. |
Hmm actually, ts5 is not okay with it with node16 👀 |
Understood, thanks for fixing it 👍🏻 We should probably open new PR to switch from node10 and land it. |
I will open a separate PR for it |
Just a test PR, to see if this can move to Typescript-go