Use and import as types.d.ts

[saschanaz]

I don't understand the reason behind #2108 (comment), this works perfectly?

[github-actions]

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

[Bashamega]

It looks to me like it just added 2 new letters and the type. I don't see why this is beneficial.

[HolgerJeromin]

Reducing to a type import is nice.

From @jakebailey

Note that the PR moved the file to .ts; you can't import a .d.ts file straight up like that without also enabling flags that allow importing TS files.

Has this flag been set?

But changing to an .d.ts import feels fishy because TS compiler will search for a corresponding .d.ts file when importing stuff (types or not) from a .js file (with or without the extension).

[saschanaz]

We are not adding a TypeScript file import in runtime (which would require node.js experimental flag), or I'm still confused what he tried to say...

[HolgerJeromin]

We are not adding a TypeScript file import in runtime (which would require node.js experimental flag), or I'm still confused what he tried to say...

Jake's comment:

Note that the PR moved the file to .ts; you can't import a .d.ts file straight up like that without also enabling flags that allow importing TS files.

I think he meant the TS flag/config allowImportingTsExtensions which allows importing .ts files. Which is otherwise not valid even for type-only imports.

[jakebailey]

This is pretty atypical. Auto imports will never suggest these paths, and for more real published packages, you'd want to avoid this because you'd end up with files that are unimportable because there's no JS file left to do it. I don't even remember if these d.ts input files are even written back out to the output...

We are not adding a TypeScript file import in runtime (which would require node.js experimental flag), or I'm still confused what he tried to say...

FWIW running TS directly is no longer experimental in 22/24, so I would honestly consider just using a higher minimum in the repo and just use that feature (with requisite tsconfig options). It works well.