Skip to content

Fix Set of one string literal bug in openExternalProject #59686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Aug 19, 2024

No test changed, which is... interesting.

Noted in #59683 (comment)

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 19, 2024
@jakebailey jakebailey merged commit 6894ff7 into microsoft:main Aug 19, 2024
32 checks passed
@jakebailey jakebailey deleted the fix-set-of-string-bug branch August 19, 2024 20:44
@sheetalkamat
Copy link
Member

No test changed, which is... interesting.

this is just is fast path to not iterate over projects to keep for this external project. Without this change, we will iterate and retain configured projects for this external project so no change as such in baseline

@sandersn sandersn removed this from PR Backlog Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants