Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM update 2025/01/16 #60987

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DOM update 2025/01/16 #60987

wants to merge 3 commits into from
+1,021 −208

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jan 16, 2025 •
edited
Loading

Fixes #60985

Changes:

  • ImageDecoder and ImageTrack added
  • NavigationActivation and NavigationHistory added
  • PageReveal and PageSwap events added
  • ViewTransitionTypeSet added
  • non-existent instance method AbortSignal#any is deleted. Static method AbortSignal.any remains.
  • many new properties on RTC stats types
  • one new ARIAMixin property
  • CSS*Rule types now include media and style accessors.
  • New CSSNestedDeclarations (nothing but a style accessor)
  • New CSSViewTransitionRule
  • CSSStyleDeclaration new properties
    • textBox
    • textBoxEdge
    • textBoxTrim
    • viewTransitionClass
  • Document.location and Window.location now has stricter get/set types:
    • get location(): Location is unchanged
    • set location(href: string) previously allowed Location (probably because of Typescript's accessor assignability rules)
  • AnimationEvent is now deprecated
  • Document.write is now deprecated
  • Element adds classList, part, style accessors
  • New type GPUError with one property message
  • HTML*Element adds various new accessors
  • Same for SVG*Element
  • HTMLBlobElement.toBlob/toDataURL require number for their last parameters, not any
  • New base type for MessagePortEventMap: MessageEventTargetEventMap
  • MessagePort and Worker extend new type MessageEventTarget which now has MessagePort/Worker's onmessage/onmessageerror methods
  • SubtleCrypto.generateKey's algorithm parameter now accepts both "Ed25519" and { name: "Ed25519" }
  • PermissionName union now includes "camera" and "microphone"
  • several other new unions

DT errors:

  • several shims need updating: webrtc, dom-webcodecs, dom-navigation
  • Worker.onmessage's this parameter is less specific: MessageEventTarget not Worker: rusha

Notes:

  • This sounds incorrect so I'm going to check. 5 top400 projects failed with the same problem, including vscode.
  • MDN agrees that it should still be a MessageEvent.
  • WhatWG shows that MessagePort includes MessageEventTarget, and although MessageEventTarget.onmessage is typed EventHandler in the IDL snippet, it also has an additional table giving "Event handler event type" for onmessage as message which has type MessageEvent. I think the IDL must incorrectly drop this.
  • Yep. There are existing overrides in Worker and MessagePort that didn't get moved when their events got refactored to MessageEventTarget.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 16, 2025
jakebailey
jakebailey reviewed Jan 16, 2025
View reviewed changes
tests/cases/conformance/jsdoc/importTag23.ts Outdated
@@ -0,0 +1,26 @@
// @Filename: /tsconfig.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a random added file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I didn't think I added it

@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 16, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/60987/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-navigation
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-navigation/index.d.ts
  70:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigationHistoryEntry'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: webrtc
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/webrtc/RTCPeerConnection.d.ts
  84:6  error  TypeScript@local compile error: 
Duplicate identifier 'RTCIceRole'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: synaptic
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/synaptic/synaptic-tests.ts
  295:41  error  TypeScript@local compile error: 
Property 'data' does not exist on type 'Event'  @definitelytyped/expect
  297:15  error  TypeScript@local compile error: 
Property 'data' does not exist on type 'Event'  @definitelytyped/expect
  317:15  error  TypeScript@local compile error: 
Property 'data' does not exist on type 'Event'  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget, ev: Event) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget, ev: Event) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-webcodecs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 193,754k (± 0.76%) 193,753k (± 0.81%) ~ 193,082k 196,973k p=0.689 n=6
Parse Time 1.31s (± 0.84%) 1.31s (± 0.48%) ~ 1.30s 1.32s p=0.787 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.77s (± 0.36%) 9.74s (± 0.61%) ~ 9.67s 9.82s p=0.573 n=6
Emit Time 2.74s (± 0.78%) 2.74s (± 0.72%) ~ 2.71s 2.77s p=0.806 n=6
Total Time 14.55s (± 0.33%) 14.52s (± 0.37%) ~ 14.44s 14.57s p=0.372 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 39 🔻+2 (+ 5.41%) ~ ~ p=0.001 n=6
Symbols 947,969 948,451 +482 (+ 0.05%) ~ ~ p=0.001 n=6
Types 410,955 410,992 +37 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 1,225,681k (± 0.00%) 1,225,232k (± 0.00%) -449k (- 0.04%) 1,225,176k 1,225,344k p=0.005 n=6
Parse Time 6.61s (± 0.92%) 6.68s (± 0.28%) ~ 6.65s 6.70s p=0.065 n=6
Bind Time 1.90s (± 0.40%) 1.89s (± 0.72%) ~ 1.88s 1.91s p=0.281 n=6
Check Time 31.94s (± 0.13%) 32.05s (± 0.27%) +0.11s (+ 0.35%) 31.94s 32.18s p=0.025 n=6
Emit Time 15.11s (± 0.96%) 15.17s (± 0.79%) ~ 14.94s 15.28s p=0.297 n=6
Total Time 55.56s (± 0.38%) 55.79s (± 0.29%) ~ 55.49s 55.91s p=0.066 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,444,602 2,445,192 +590 (+ 0.02%) ~ ~ p=0.001 n=6
Types 896,634 896,664 +30 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,305,650k (± 0.00%) 2,306,240k (± 0.01%) +590k (+ 0.03%) 2,306,090k 2,306,541k p=0.005 n=6
Parse Time 8.91s (± 0.49%) 8.91s (± 0.38%) ~ 8.88s 8.96s p=1.000 n=6
Bind Time 2.12s (± 0.30%) 2.11s (± 0.50%) ~ 2.10s 2.13s p=0.388 n=6
Check Time 72.96s (± 0.14%) 73.52s (± 0.40%) +0.56s (+ 0.76%) 73.19s 73.91s p=0.005 n=6
Emit Time 0.28s (± 3.53%) 0.27s (± 1.50%) ~ 0.27s 0.28s p=0.213 n=6
Total Time 84.27s (± 0.14%) 84.82s (± 0.33%) +0.55s (+ 0.65%) 84.51s 85.20s p=0.005 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,377 ~ ~ ~ p=1.000 n=6
Types 266,839 266,839 ~ ~ ~ p=1.000 n=6
Memory used 2,753,194k (±13.61%) 2,970,579k (±10.02%) ~ 2,362,247k 3,092,951k p=0.230 n=6
Parse Time 6.68s (± 1.06%) 6.74s (± 1.64%) ~ 6.53s 6.84s p=0.228 n=6
Bind Time 2.17s (± 1.44%) 2.16s (± 1.16%) ~ 2.11s 2.18s p=0.520 n=6
Check Time 42.73s (± 0.48%) 42.87s (± 0.31%) ~ 42.70s 43.08s p=0.173 n=6
Emit Time 3.47s (± 2.38%) 3.49s (± 3.59%) ~ 3.34s 3.68s p=1.000 n=6
Total Time 55.06s (± 0.46%) 55.25s (± 0.33%) ~ 54.96s 55.51s p=0.230 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,377 ~ ~ ~ p=1.000 n=6
Types 266,839 266,839 ~ ~ ~ p=1.000 n=6
Memory used 2,427,357k (± 0.01%) 2,427,149k (± 0.01%) ~ 2,426,783k 2,427,560k p=0.298 n=6
Parse Time 5.49s (± 0.80%) 5.50s (± 1.11%) ~ 5.44s 5.59s p=0.936 n=6
Bind Time 1.81s (± 0.70%) 1.79s (± 1.19%) ~ 1.76s 1.81s p=0.210 n=6
Check Time 35.41s (± 0.67%) 35.35s (± 0.37%) ~ 35.19s 35.58s p=0.423 n=6
Emit Time 3.06s (± 1.05%) 3.06s (± 0.93%) ~ 3.01s 3.09s p=1.000 n=6
Total Time 45.78s (± 0.57%) 45.72s (± 0.32%) ~ 45.52s 45.92s p=0.936 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,624 262,624 ~ ~ ~ p=1.000 n=6
Types 106,695 106,695 ~ ~ ~ p=1.000 n=6
Memory used 440,803k (± 0.02%) 440,767k (± 0.02%) ~ 440,690k 440,840k p=0.471 n=6
Parse Time 3.54s (± 0.95%) 3.56s (± 0.79%) ~ 3.53s 3.60s p=0.222 n=6
Bind Time 1.32s (± 0.96%) 1.32s (± 0.92%) ~ 1.30s 1.33s p=0.675 n=6
Check Time 18.97s (± 0.34%) 19.00s (± 0.29%) ~ 18.90s 19.06s p=0.419 n=6
Emit Time 1.53s (± 0.69%) 1.54s (± 1.28%) ~ 1.52s 1.57s p=0.361 n=6
Total Time 25.35s (± 0.36%) 25.41s (± 0.28%) ~ 25.28s 25.48s p=0.294 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,095 226,095 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,696k (± 0.03%) 371,677k (± 0.02%) ~ 371,590k 371,777k p=1.000 n=6
Parse Time 2.92s (± 0.80%) 2.91s (± 0.90%) ~ 2.88s 2.95s p=0.685 n=6
Bind Time 1.60s (± 0.79%) 1.60s (± 0.83%) ~ 1.58s 1.62s p=0.742 n=6
Check Time 16.49s (± 0.52%) 16.49s (± 0.33%) ~ 16.41s 16.57s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.01s (± 0.50%) 21.00s (± 0.32%) ~ 20.93s 21.12s p=1.000 n=6
vscode - node (v18.15.0, x64)
Errors 3 19 🔻+16 (+533.33%) ~ ~ p=0.001 n=6
Symbols 3,252,172 3,253,290 +1,118 (+ 0.03%) ~ ~ p=0.001 n=6
Types 1,119,176 1,119,352 +176 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 3,316,385k (± 0.01%) 3,317,437k (± 0.01%) +1,052k (+ 0.03%) 3,317,035k 3,317,707k p=0.005 n=6
Parse Time 14.26s (± 0.59%) 14.15s (± 0.40%) ~ 14.09s 14.26s p=0.065 n=6
Bind Time 4.58s (± 0.35%) 4.59s (± 0.25%) ~ 4.57s 4.60s p=0.287 n=6
Check Time 89.09s (± 2.27%) 90.47s (± 2.50%) ~ 87.70s 93.54s p=0.471 n=6
Emit Time 28.75s (± 2.37%) 28.01s (± 1.78%) ~ 27.56s 28.89s p=0.093 n=6
Total Time 136.67s (± 1.79%) 137.22s (± 1.73%) ~ 134.31s 140.06s p=0.810 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 291,595 292,487 +892 (+ 0.31%) ~ ~ p=0.001 n=6
Types 118,971 119,092 +121 (+ 0.10%) ~ ~ p=0.001 n=6
Memory used 445,325k (± 0.01%) 446,020k (± 0.01%) +695k (+ 0.16%) 445,904k 446,076k p=0.005 n=6
Parse Time 5.09s (± 1.49%) 5.08s (± 0.94%) ~ 5.03s 5.16s p=0.423 n=6
Bind Time 2.21s (± 1.17%) 2.25s (± 0.87%) ~ 2.22s 2.27s p=0.056 n=6
Check Time 23.34s (± 0.32%) 23.31s (± 0.83%) ~ 23.05s 23.51s p=1.000 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.65s (± 0.45%) 30.64s (± 0.66%) ~ 30.39s 30.93s p=0.936 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,050 555,357 +307 (+ 0.06%) ~ ~ p=0.001 n=6
Types 186,115 186,151 +36 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 494,020k (± 0.01%) 494,417k (± 0.01%) +397k (+ 0.08%) 494,368k 494,466k p=0.005 n=6
Parse Time 3.41s (± 0.68%) 3.42s (± 0.80%) ~ 3.38s 3.45s p=1.000 n=6
Bind Time 1.18s (± 0.71%) 1.20s (± 0.88%) ~ 1.18s 1.21s p=0.122 n=6
Check Time 19.52s (± 0.63%) 19.63s (± 0.35%) ~ 19.56s 19.74s p=0.078 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.12s (± 0.47%) 24.24s (± 0.26%) ~ 24.18s 24.33s p=0.065 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60987/merge:

Something interesting changed - please have a look.

Details

desktop/desktop

1 of 5 projects failed to build with the old tsc and were ignored

tsconfig.json

app/src/highlighter/tsconfig.json

  • error TS2322: Type '(ev: MessageEvent<IHighlightRequest>) => Promise<void>' is not assignable to type '(this: DedicatedWorkerGlobalScope, ev: Event) => any'.

freeCodeCamp/freeCodeCamp

5 of 8 projects failed to build with the old tsc and were ignored

tools/client-plugins/browser-scripts/tsconfig.json

lyswhut/lx-music-desktop

4 of 6 projects failed to build with the old tsc and were ignored

src/renderer-lyric/tsconfig.json

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

src/tsconfig.monaco.json

extensions/typescript-language-features/tsconfig.json

extensions/json-language-features/server/tsconfig.json

extensions/ipynb/tsconfig.json

extensions/html-language-features/server/tsconfig.json

extensions/css-language-features/server/tsconfig.json

QwikDev/partytown

1 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2322: Type '(ev: MessageEvent<MessageFromWorkerToSandbox>) => void' is not assignable to type '(this: MessageEventTarget, ev: Event) => any'.

@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 17, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started 👀 Results
user test this ✅ Started ✅ Results
run dt ✅ Started 👀 Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-navigation
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-navigation/index.d.ts
  70:15  error  TypeScript@local compile error: 
Duplicate identifier 'NavigationHistoryEntry'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: webrtc
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/webrtc/RTCPeerConnection.d.ts
  84:6  error  TypeScript@local compile error: 
Duplicate identifier 'RTCIceRole'  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: rusha
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/rusha/index.d.ts
  19:11  error  TypeScript@local compile error: 
Interface 'RushaWorker' incorrectly extends interface 'Worker'.
  Types of property 'onmessage' are incompatible.
    Type '((this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void) | null' is not assignable to type '((this: MessageEventTarget, ev: MessageEvent<any>) => any) | null'.
      Type '(this: RushaWorker, res: MessageEvent<RushaWorkerResponse>) => void' is not assignable to type '(this: MessageEventTarget, ev: MessageEvent<any>) => any'.
        The 'this' types of each signature are incompatible.
          Type 'MessageEventTarget' is missing the following properties from type 'RushaWorker': postMessage, terminate, dispatchEvent, onerror  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: dom-webcodecs
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/test/dom-webcodecs-tests.ts
  319:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-webcodecs/webcodecs.generated.d.ts
  324:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'completed' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect
  352:14  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'      @definitelytyped/expect
  505:6   error  TypeScript@local compile error: 
Duplicate identifier 'ImageBufferSource'                                                                                                                 @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/60987/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 194,375k (± 0.95%) 194,351k (± 1.00%) ~ 193,077k 196,971k p=1.000 n=6
Parse Time 1.31s (± 0.84%) 1.31s (± 0.31%) ~ 1.31s 1.32s p=0.445 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.74s (± 0.27%) 9.78s (± 0.11%) +0.03s (+ 0.32%) 9.76s 9.79s p=0.022 n=6
Emit Time 2.73s (± 0.71%) 2.75s (± 1.19%) ~ 2.71s 2.79s p=0.747 n=6
Total Time 14.52s (± 0.30%) 14.56s (± 0.21%) ~ 14.52s 14.61s p=0.076 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 947,969 948,451 +482 (+ 0.05%) ~ ~ p=0.001 n=6
Types 410,955 410,992 +37 (+ 0.01%) ~ ~ p=0.001 n=6
Memory used 1,225,657k (± 0.00%) 1,225,296k (± 0.00%) -361k (- 0.03%) 1,225,266k 1,225,357k p=0.005 n=6
Parse Time 6.63s (± 1.17%) 6.67s (± 0.87%) ~ 6.56s 6.71s p=0.520 n=6
Bind Time 1.90s (± 0.47%) 1.90s (± 0.52%) ~ 1.89s 1.91s p=0.798 n=6
Check Time 31.94s (± 0.32%) 31.97s (± 0.14%) ~ 31.90s 32.02s p=0.630 n=6
Emit Time 15.24s (± 0.63%) 15.22s (± 0.48%) ~ 15.10s 15.31s p=0.873 n=6
Total Time 55.72s (± 0.29%) 55.75s (± 0.14%) ~ 55.65s 55.87s p=0.521 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,444,602 2,445,192 +590 (+ 0.02%) ~ ~ p=0.001 n=6
Types 896,634 896,664 +30 (+ 0.00%) ~ ~ p=0.001 n=6
Memory used 2,305,621k (± 0.00%) 2,306,230k (± 0.01%) +609k (+ 0.03%) 2,306,020k 2,306,460k p=0.005 n=6
Parse Time 8.89s (± 0.45%) 8.90s (± 0.51%) ~ 8.85s 8.98s p=0.747 n=6
Bind Time 2.12s (± 0.46%) 2.12s (± 0.38%) ~ 2.11s 2.13s p=0.604 n=6
Check Time 73.15s (± 0.36%) 73.17s (± 0.17%) ~ 72.99s 73.32s p=0.689 n=6
Emit Time 0.28s (± 1.47%) 0.28s (± 2.70%) ~ 0.27s 0.29s p=1.000 n=6
Total Time 84.44s (± 0.30%) 84.47s (± 0.16%) ~ 84.25s 84.62s p=0.810 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,377 ~ ~ ~ p=1.000 n=6
Types 266,839 266,839 ~ ~ ~ p=1.000 n=6
Memory used 2,360,196k (± 0.01%) 2,359,646k (± 0.02%) ~ 2,358,994k 2,360,066k p=0.066 n=6
Parse Time 5.18s (± 0.87%) 5.21s (± 0.74%) ~ 5.14s 5.25s p=0.228 n=6
Bind Time 1.79s (± 1.52%) 1.76s (± 0.98%) ~ 1.74s 1.79s p=0.073 n=6
Check Time 35.25s (± 0.24%) 35.24s (± 0.35%) ~ 35.16s 35.49s p=0.688 n=6
Emit Time 3.00s (± 1.36%) 2.98s (± 0.81%) ~ 2.96s 3.02s p=0.809 n=6
Total Time 45.21s (± 0.26%) 45.22s (± 0.41%) ~ 45.02s 45.55s p=0.630 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,228,377 1,228,377 ~ ~ ~ p=1.000 n=6
Types 266,839 266,839 ~ ~ ~ p=1.000 n=6
Memory used 3,062,488k (± 7.57%) 2,915,564k (±12.85%) ~ 2,431,232k 3,158,334k p=1.000 n=6
Parse Time 7.02s (± 1.15%) 6.93s (± 1.74%) ~ 6.80s 7.12s p=0.378 n=6
Bind Time 2.15s (± 1.21%) 2.15s (± 1.94%) ~ 2.09s 2.19s p=1.000 n=6
Check Time 42.82s (± 0.83%) 42.81s (± 0.52%) ~ 42.55s 43.09s p=0.689 n=6
Emit Time 3.48s (± 1.94%) 3.48s (± 2.84%) ~ 3.36s 3.60s p=0.521 n=6
Total Time 55.47s (± 0.72%) 55.40s (± 0.57%) ~ 55.00s 55.94s p=0.378 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 262,624 262,624 ~ ~ ~ p=1.000 n=6
Types 106,695 106,695 ~ ~ ~ p=1.000 n=6
Memory used 440,778k (± 0.02%) 440,783k (± 0.01%) ~ 440,681k 440,833k p=0.872 n=6
Parse Time 3.53s (± 1.23%) 3.54s (± 0.66%) ~ 3.51s 3.57s p=0.746 n=6
Bind Time 1.32s (± 1.12%) 1.31s (± 0.75%) ~ 1.30s 1.33s p=0.440 n=6
Check Time 18.94s (± 0.64%) 18.92s (± 0.48%) ~ 18.83s 19.07s p=1.000 n=6
Emit Time 1.53s (± 1.29%) 1.54s (± 1.00%) ~ 1.52s 1.56s p=0.194 n=6
Total Time 25.31s (± 0.63%) 25.31s (± 0.44%) ~ 25.19s 25.47s p=0.810 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,095 226,095 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,693k (± 0.02%) 371,685k (± 0.01%) ~ 371,630k 371,735k p=0.810 n=6
Parse Time 2.91s (± 1.21%) 2.91s (± 0.93%) ~ 2.88s 2.95s p=1.000 n=6
Bind Time 1.60s (± 1.53%) 1.61s (± 1.28%) ~ 1.58s 1.63s p=0.685 n=6
Check Time 16.50s (± 0.43%) 16.46s (± 0.30%) ~ 16.38s 16.53s p=0.336 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 21.02s (± 0.52%) 20.97s (± 0.37%) ~ 20.85s 21.08s p=0.748 n=6
vscode - node (v18.15.0, x64)
Errors 3 5 🔻+2 (+66.67%) ~ ~ p=0.001 n=6
Symbols 3,251,240 3,252,358 +1,118 (+ 0.03%) ~ ~ p=0.001 n=6
Types 1,118,923 1,119,099 +176 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 3,316,387k (± 0.01%) 3,317,125k (± 0.01%) +738k (+ 0.02%) 3,316,708k 3,317,443k p=0.005 n=6
Parse Time 14.20s (± 0.78%) 14.22s (± 0.52%) ~ 14.15s 14.32s p=0.471 n=6
Bind Time 4.57s (± 0.57%) 4.59s (± 0.68%) ~ 4.57s 4.65s p=0.372 n=6
Check Time 88.77s (± 2.05%) 89.88s (± 3.03%) ~ 87.41s 94.48s p=0.471 n=6
Emit Time 27.30s (± 7.10%) 27.69s (± 8.10%) ~ 23.28s 29.28s p=0.471 n=6
Total Time 134.85s (± 0.81%) 136.39s (± 2.40%) ~ 133.21s 142.58s p=0.378 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 291,595 292,485 +890 (+ 0.31%) ~ ~ p=0.001 n=6
Types 118,971 119,091 +120 (+ 0.10%) ~ ~ p=0.001 n=6
Memory used 445,363k (± 0.03%) 446,053k (± 0.03%) +690k (+ 0.15%) 445,924k 446,270k p=0.005 n=6
Parse Time 5.03s (± 1.43%) 5.09s (± 1.14%) ~ 5.01s 5.16s p=0.107 n=6
Bind Time 2.22s (± 1.64%) 2.23s (± 1.29%) ~ 2.21s 2.28s p=0.934 n=6
Check Time 23.34s (± 0.54%) 23.36s (± 0.52%) ~ 23.26s 23.58s p=0.873 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.60s (± 0.65%) 30.67s (± 0.52%) ~ 30.48s 30.89s p=0.521 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,050 555,357 +307 (+ 0.06%) ~ ~ p=0.001 n=6
Types 186,115 186,151 +36 (+ 0.02%) ~ ~ p=0.001 n=6
Memory used 494,051k (± 0.01%) 494,412k (± 0.01%) +361k (+ 0.07%) 494,346k 494,472k p=0.005 n=6
Parse Time 3.42s (± 0.60%) 3.41s (± 0.54%) ~ 3.38s 3.43s p=0.569 n=6
Bind Time 1.18s (± 1.15%) 1.18s (± 1.36%) ~ 1.15s 1.19s p=0.806 n=6
Check Time 19.56s (± 0.44%) 19.58s (± 0.49%) ~ 19.43s 19.68s p=0.810 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.16s (± 0.38%) 24.17s (± 0.37%) ~ 24.02s 24.27s p=1.000 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60987/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

extensions/json-language-features/server/tsconfig.json

extensions/html-language-features/server/tsconfig.json

extensions/css-language-features/server/tsconfig.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lib.d.ts Updates for TypeScript 5.8
3 participants
@sandersn @typescript-bot @jakebailey