Fixed Japanese translations for messages 1259, 2556, 2620, 2621, 2706, and 18046 #62120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These files are maintained by our localization team and can't really be updated externally (they push them here). I don't think we can accept this PR. |
|
I'm disappointed to hear that, as I submitted this PR because issue #53337 has a "Help Wanted" label. I understand you can't accept this PR, but I hope the incorrect translations can still be fixed. Messages 2620, 2621, and 2706 have meanings that are opposite to what they should be. How can I help get these corrected? |
|
Sorry for the incorrect tag on that one, I missed something there. I'll try to track down who is in charge of the loc files these days. |
|
@RyanCavanaugh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53337
Testing
I did not add unit tests for this change because:
/path/to/TypeScript/built/local/tsc.js --locale jalocally and confirmed that the expected error messages are displayed correctlyThe change is a straightforward localization fix that aligns the Japanese error message with the English version, and manual testing confirms the expected behavior.