Derive disposability checks from known symbols rather than global interfaces #62122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where TypeScript's disposability checking for
using
andawait using
declarations was vulnerable to user modifications of globalDisposable
andAsyncDisposable
interfaces.Problem
Previously, the checker determined disposability by testing assignability against global
Disposable
/AsyncDisposable
interfaces. This approach had a significant weakness: any script that declared an empty global interface could unintentionally modify the checker's behavior:Solution
This PR changes the disposability checking to directly examine
Symbol.dispose
andSymbol.asyncDispose
properties, following the same pattern used for iteration checks withSymbol.iterator
.The key changes:
checkTypeIsDisposable()
andcheckTypeIsAsyncDisposable()
that usegetPropertyNameForKnownSymbolName()
to check for the actual symbol propertiesusing
andawait using
declaration checking to use these symbol-based checks instead of global interface assignabilityExample
With this fix, disposability is determined by the presence of the actual symbol methods:
Testing
using
declaration tests continue to passFixes #62121.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.