Skip to content

Fix(deprecation): report method name instead of type for deprecated methods #62406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −4
Open

Fix(deprecation): report method name instead of type for deprecated methods #62406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1e8b2
fix(deprecation): report method name instead of type for deprecated m…
hanseul37 Sep 5, 2025
f769c11
fix(deprecation): show method name instead of type in deprecated mess…
hanseul37 Sep 8, 2025
35a214d
Merge branch 'main' into fix62396
hanseul37 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2611,10 +2611,15 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
return addDeprecatedSuggestionWorker(declarations, diagnostic);
}

function addDeprecatedSuggestionWithSignature(location: Node, declaration: Node, deprecatedEntity: string | undefined, signatureString: string) {
function addDeprecatedSuggestionWithSignature(location: Node, declaration: Node, deprecatedEntity: string | undefined, signatureString: string, invoked?: Expression) {
let nameFromInvoked = "<unknown>";
if (invoked && invoked.kind === SyntaxKind.PropertyAccessExpression) {
const propAccess = invoked as PropertyAccessExpression;
nameFromInvoked = (propAccess.name as any).getText() + "()";
}
const diagnostic = deprecatedEntity
? createDiagnosticForNode(location, Diagnostics.The_signature_0_of_1_is_deprecated, signatureString, deprecatedEntity)
: createDiagnosticForNode(location, Diagnostics._0_is_deprecated, signatureString);
: createDiagnosticForNode(location, Diagnostics._0_is_deprecated, nameFromInvoked);
return addDeprecatedSuggestionWorker(declaration, diagnostic);
}

Expand Down Expand Up @@ -37782,8 +37787,14 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (signature.flags & SignatureFlags.IsSignatureCandidateForOverloadFailure) return;
if (signature.declaration && signature.declaration.flags & NodeFlags.Deprecated) {
const suggestionNode = getDeprecatedSuggestionNode(node);
const name = tryGetPropertyAccessOrIdentifierToString(getInvokedExpression(node));
addDeprecatedSuggestionWithSignature(suggestionNode, signature.declaration, name, signatureToString(signature));
const invoked = getInvokedExpression(node);
const invokedExpr = invoked &&
invoked.kind !== SyntaxKind.JsxElement &&
invoked.kind !== SyntaxKind.JsxSelfClosingElement
? (invoked as Expression)
: undefined;
const name = tryGetPropertyAccessOrIdentifierToString(invoked);
addDeprecatedSuggestionWithSignature(suggestionNode, signature.declaration, name, signatureToString(signature), invokedExpr);
}
}

Expand Down
Loading