Properly account for start length when inferring into two variadic tuple elements when implied arity is available #62563

Andarist · 2025-10-08T10:18:03Z

…ple elements when implied arity is available

RyanCavanaugh · 2025-10-08T15:33:13Z

typescript-bot · 2025-10-08T15:33:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-10-08T15:57:01Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-10-08T16:01:48Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/62563/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-10-08T16:22:14Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,563k (± 1.01%)}	_{193,953k (± 0.94%)}	_~	_192,741k	_196,343k	_{p=0.575 n=6}
_{Parse Time}	_{1.30s (± 0.63%)}	_{1.30s (± 0.63%)}	_~	_1.29s	_1.31s	_{p=0.177 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.75s (± 0.31%)}	_{9.76s (± 0.23%)}	_~	_9.72s	_9.78s	_{p=0.569 n=6}
_{Emit Time}	_{2.76s (± 0.55%)}	_{2.74s (± 0.20%)}	_~	_2.74s	_2.75s	_{p=0.138 n=6}
_{Total Time}	_{14.54s (± 0.21%)}	_{14.52s (± 0.20%)}	_~	_14.47s	_14.55s	_{p=0.369 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,117	_955,117	_~	_~	_~	_{p=1.000 n=6}
_Types	_415,619	_415,619	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,254,530k (± 0.00%)}	_{1,254,538k (± 0.01%)}	_~	_1,254,476k	_1,254,667k	_{p=1.000 n=6}
_{Parse Time}	_{6.50s (± 0.71%)}	_{6.53s (± 0.78%)}	_~	_6.48s	_6.60s	_{p=0.296 n=6}
_{Bind Time}	_{1.88s (± 0.48%)}	_{1.88s (± 0.22%)}	_~	_1.88s	_1.89s	_{p=0.787 n=6}
_{Check Time}	_{32.16s (± 0.38%)}	_{32.15s (± 0.34%)}	_~	_32.02s	_32.30s	_{p=0.936 n=6}
_{Emit Time}	_{14.85s (± 0.67%)}	_{14.91s (± 0.34%)}	_~	_14.87s	_15.01s	_{p=0.229 n=6}
_{Total Time}	_{55.39s (± 0.29%)}	_{55.47s (± 0.19%)}	_~	_55.32s	_55.60s	_{p=0.335 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,657,287	_2,657,287	_~	_~	_~	_{p=1.000 n=6}
_Types	_920,907	_920,907	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,969,872k (± 0.00%)}	_{2,969,877k (± 0.00%)}	_~	_2,969,812k	_2,970,027k	_{p=0.936 n=6}
_{Parse Time}	_{8.67s (± 0.49%)}	_{8.64s (± 0.30%)}	_~	_8.60s	_8.68s	_{p=0.375 n=6}
_{Bind Time}	_{2.20s (± 0.23%)}	_{2.19s (± 0.85%)}	_~	_2.16s	_2.21s	_{p=1.000 n=6}
_{Check Time}	_{90.30s (± 0.52%)}	_{90.12s (± 0.10%)}	_~	_90.00s	_90.22s	_{p=0.521 n=6}
_{Emit Time}	_{0.30s (± 1.70%)}	_{0.30s (± 1.79%)}	_~	_0.30s	_0.31s	_{p=0.640 n=6}
_{Total Time}	_{101.46s (± 0.49%)}	_{101.26s (± 0.09%)}	_~	_101.12s	_101.39s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,230	_1,237,231	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,856	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,607,467k (±14.40%)}	_{2,546,474k (±11.94%)}	_~	_2,363,922k	_3,092,064k	_{p=0.810 n=6}
_{Parse Time}	_{5.16s (± 1.46%)}	_{5.18s (± 1.33%)}	_~	_5.11s	_5.27s	_{p=0.470 n=6}
_{Bind Time}	_{1.77s (± 1.11%)}	_{1.77s (± 1.15%)}	_~	_1.74s	_1.80s	_{p=0.934 n=6}
_{Check Time}	_{35.26s (± 0.63%)}	_{35.08s (± 0.73%)}	_~	_34.68s	_35.47s	_{p=0.172 n=6}
_{Emit Time}	_{2.99s (± 0.88%)}	_{3.03s (± 1.55%)}	_~	_2.96s	_3.09s	_{p=0.092 n=6}
_{Total Time}	_{45.18s (± 0.63%)}	_{45.08s (± 0.62%)}	_~	_44.75s	_45.57s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,230	_1,237,231	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_259,856	_259,856	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,158,247k (± 0.05%)}	_{3,158,744k (± 0.03%)}	_~	_3,157,832k	_3,160,604k	_{p=0.689 n=6}
_{Parse Time}	_{6.84s (± 0.66%)}	_{6.83s (± 0.44%)}	_~	_6.79s	_6.87s	_{p=0.872 n=6}
_{Bind Time}	_{2.17s (± 2.18%)}	_{2.16s (± 1.72%)}	_~	_2.12s	_2.22s	_{p=0.748 n=6}
_{Check Time}	_{42.68s (± 0.39%)}	_{42.59s (± 0.27%)}	_~	_42.46s	_42.76s	_{p=0.298 n=6}
_{Emit Time}	_{3.54s (± 4.72%)}	_{3.52s (± 2.51%)}	_~	_3.39s	_3.65s	_{p=0.810 n=6}
_{Total Time}	_{55.23s (± 0.42%)}	_{55.12s (± 0.20%)}	_~	_54.98s	_55.27s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,534	_262,535	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_104,035	_104,035	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,642k (± 0.01%)}	_{440,657k (± 0.01%)}	_~	_440,609k	_440,694k	_{p=0.378 n=6}
_{Parse Time}	_{3.50s (± 1.26%)}	_{3.53s (± 0.79%)}	_~	_3.50s	_3.58s	_{p=0.091 n=6}
_{Bind Time}	_{1.32s (± 0.78%)}	_{1.31s (± 1.34%)}	_~	_1.29s	_1.33s	_{p=1.000 n=6}
_{Check Time}	_{18.97s (± 0.23%)}	_{18.95s (± 0.32%)}	_~	_18.87s	_19.05s	_{p=0.520 n=6}
_{Emit Time}	_{1.53s (± 1.57%)}	_{1.54s (± 1.21%)}	_~	_1.51s	_1.56s	_{p=0.288 n=6}
_{Total Time}	_{25.32s (± 0.26%)}	_{25.34s (± 0.31%)}	_~	_25.23s	_25.44s	_{p=0.571 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,012k (± 0.02%)}	_{370,177k (± 0.07%)}	_~	_369,959k	_370,650k	_{p=0.471 n=6}
_{Parse Time}	_{2.86s (± 0.69%)}	_{2.85s (± 0.97%)}	_~	_2.82s	_2.89s	_{p=0.517 n=6}
_{Bind Time}	_{1.62s (± 1.27%)}	_{1.62s (± 0.85%)}	_~	_1.60s	_1.64s	_{p=0.459 n=6}
_{Check Time}	_{16.45s (± 0.33%)}	_{16.47s (± 0.36%)}	_~	_16.39s	_16.53s	_{p=0.687 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.93s (± 0.30%)}	_{20.93s (± 0.31%)}	_~	_20.83s	_21.01s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₆	₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,912,367	_3,912,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,230,260	_1,230,260	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,718,681k (± 0.01%)}	_{3,718,927k (± 0.00%)}	_~	_3,718,740k	_3,719,049k	_{p=0.128 n=6}
_{Parse Time}	_{15.12s (± 1.03%)}	_{15.14s (± 0.57%)}	_~	_15.08s	_15.31s	_{p=0.810 n=6}
_{Bind Time}	_{4.95s (± 2.22%)}	_{4.97s (± 2.17%)}	_~	_4.86s	_5.17s	_{p=0.570 n=6}
_{Check Time}	_{101.57s (± 3.07%)}	_{100.94s (± 1.41%)}	_~	_99.57s	_102.83s	_{p=0.810 n=6}
_{Emit Time}	_{37.26s (±23.42%)}	_{35.52s (±17.56%)}	_~	_30.44s	_46.28s	_{p=0.936 n=6}
_{Total Time}	_{158.90s (± 5.36%)}	_{156.57s (± 4.71%)}	_~	_150.19s	_169.40s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_372,291	_372,291	_~	_~	_~	_{p=1.000 n=6}
_Types	_163,107	_163,107	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{528,328k (± 0.01%)}	_{528,362k (± 0.02%)}	_~	_528,261k	_528,589k	_{p=0.936 n=6}
_{Parse Time}	_{4.48s (± 0.32%)}	_{4.48s (± 0.23%)}	_~	_4.47s	_4.50s	_{p=0.738 n=6}
_{Bind Time}	_{1.93s (± 2.42%)}	_{1.90s (± 1.46%)}	_~	_1.85s	_1.93s	_{p=0.572 n=6}
_{Check Time}	_{22.09s (± 0.39%)}	_{22.02s (± 0.48%)}	_~	_21.87s	_22.15s	_{p=0.261 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{28.51s (± 0.34%)}	_{28.41s (± 0.46%)}	_~	_28.20s	_28.58s	_{p=0.229 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_674,449	_674,449	_~	_~	_~	_{p=1.000 n=6}
_Types	_202,276	_202,276	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{576,741k (± 0.02%)}	_{576,781k (± 0.02%)}	_~	_576,595k	_576,867k	_{p=0.689 n=6}
_{Parse Time}	_{4.18s (± 0.60%)}	_{4.19s (± 0.48%)}	_~	_4.16s	_4.22s	_{p=0.685 n=6}
_{Bind Time}	_{1.34s (± 1.22%)}	_{1.36s (± 0.86%)}	_~	_1.34s	_1.37s	_{p=0.164 n=6}
_{Check Time}	_{20.44s (± 2.03%)}	_{20.37s (± 1.70%)}	_~	_20.10s	_21.05s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.97s (± 1.60%)}	_{25.92s (± 1.37%)}	_~	_25.63s	_26.61s	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-10-08T16:51:48Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62563/merge:

Everything looks good!

Properly account for start length when inferring into two variadic tu…

6d4d06b

…ple elements when implied arity is available

github-project-automation bot added this to PR Backlog Oct 8, 2025

github-project-automation bot moved this to Not started in PR Backlog Oct 8, 2025

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 8, 2025

Andarist added 4 commits October 8, 2025 12:46

fix computation

e7ad723

simplify

a340459

more tests

8bd5c85

make computation clearer

5942d7b

Andarist mentioned this pull request Oct 9, 2025

Two consecutive variadic elements in the middle part of tuple type can't be recognized #62561

Open

RyanCavanaugh requested a review from ahejlsberg October 9, 2025 22:43

typescript-bot assigned ahejlsberg Oct 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Properly account for start length when inferring into two variadic tuple elements when implied arity is available #62563

Properly account for start length when inferring into two variadic tuple elements when implied arity is available #62563

Andarist commented Oct 8, 2025

Uh oh!

RyanCavanaugh commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025

tsc

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Properly account for start length when inferring into two variadic tuple elements when implied arity is available #62563

Are you sure you want to change the base?

Properly account for start length when inferring into two variadic tuple elements when implied arity is available #62563

Conversation

Andarist commented Oct 8, 2025

Uh oh!

RyanCavanaugh commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

typescript-bot commented Oct 8, 2025

tsc

Uh oh!

typescript-bot commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

typescript-bot commented Oct 8, 2025 •

edited

Loading