This repository was archived by the owner on Oct 12, 2022. It is now read-only.
added angular 1.x sample #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ``` | ||
| and visit : http://localhost:8000/app/ | ||
|
|
||
| ## Upgrading |
There was a problem hiding this comment.
is this needed for the readme? on another note "upgrading" sounded to vague to me.
|
Thanks @basarat 🌻; just a few comments. |
|
Addressed the comments:
|
| tsc --watch --p e2e-tests | ||
| ``` | ||
|
|
||
| That's it. You have typescript setup and ready to go. You can follow the steps of JavaScript ([README-JS](./README-JS.md)) from this point on in a new window starting at the install dependencies section. |
There was a problem hiding this comment.
Nit: You can, then, follow the standard steps for seeded AngularJS web app in a new window, using README-JS starting at the section, Install Dependencies.
|
Thanks @basarat. The instruction is very easy to follow when I tried it out :) Just small suggestions otherwise the PR look good 👍 🌷 |
|
|
||
| angular.module('myApp.version.interpolate-filter', []) | ||
|
|
||
| .filter('interpolate', ['version', function(version) { |
There was a problem hiding this comment.
I think it'd be great if this sample worked under --noImplicitAny. Maybe in a future PR
|
Thanks again @basarat ! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #12
Details available in README.md : https://github.com/basarat/TypeScriptSamples/blob/angular1/angular1/README.md which is a part of this PR 🌹