Skip to content

Comments

SPECviewperf: PsExec, Individual Scores, and more unit tests#192

Merged
yangpanMS merged 40 commits intomicrosoft:mainfrom
LiYueqian-James:users/yueqianli/specviewperf
Nov 9, 2023
Merged

SPECviewperf: PsExec, Individual Scores, and more unit tests#192
yangpanMS merged 40 commits intomicrosoft:mainfrom
LiYueqian-James:users/yueqianli/specviewperf

Conversation

@LiYueqian-James
Copy link
Contributor

@LiYueqian-James LiYueqian-James commented Oct 18, 2023

  1. SPECview now uses PsExec to force it to run in session 1
  2. All the individual test scores, along with their weights, will be logged as metrics.
  3. Added unit tests for metrics parser (verifying all the individual test scores and metadata)
  4. Added unit tests for uploading specviewperf log files.

@LiYueqian-James LiYueqian-James changed the title Added PsExec to execute specviewperf in session 1 SPECviewperf: PsExec, Individual Scores, and more unit tests Oct 19, 2023
@LiYueqian-James LiYueqian-James marked this pull request as ready for review October 19, 2023 23:16
Copy link
Contributor Author

@LiYueqian-James LiYueqian-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted comment]

@yangpanMS yangpanMS merged commit dfac9b1 into microsoft:main Nov 9, 2023
muskankhedia pushed a commit to muskankhedia/VirtualClient that referenced this pull request Nov 24, 2023
…ft#192)

* added specview perf to main.csproj

* updated the default viewset parameter

* added support for uploading log files

* bumped up vc version

* removed upload file feature from unit tests

* removed extra whitespaces

* added pstools

* psexec unit tests

* added file upload unit tests

* vc version and formatting

* made psexec a separate param

* added psExec param to doc

* fixed pr comments; passed uni tests

* updated specviewperf docs

* more example metrics

* aligned

* fixed merge errors

* spec 2020 3.1

* renamed packages with name-version format

* fixed package format

* updated supported systems

* updated specview doc

* gpu model

* Update specview-profiles.md

Signed-off-by: James Li <60281808+LiYueqian-James@users.noreply.github.com>

* updated unit tests

---------

Signed-off-by: James Li <60281808+LiYueqian-James@users.noreply.github.com>
@LiYueqian-James LiYueqian-James deleted the users/yueqianli/specviewperf branch December 29, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants