Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memtier results aggregation #196

Merged
merged 7 commits into from
Nov 22, 2023

Conversation

nmalkapuram
Copy link
Contributor

Aggregate metrics for memtier client for both redis and memcached server process.

Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For metric changes could you please add changes for both metric documents and also the unit test?

@yangpanMS
Copy link
Contributor

Also please rename the title

@nmalkapuram nmalkapuram changed the title Users/nmalkapuram/memtier results aggregation Memtier results aggregation Nov 1, 2023
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MemtierResultsAggregation branch 3 times, most recently from 4c4e2cb to 68f9ab9 Compare November 8, 2023 19:35
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MemtierResultsAggregation branch from 0f841dd to f751032 Compare November 15, 2023 04:43
@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/MemtierResultsAggregation branch from f751032 to 7df089e Compare November 21, 2023 15:59
@nmalkapuram nmalkapuram merged commit d27d57c into main Nov 22, 2023
3 checks passed
@nmalkapuram nmalkapuram deleted the users/nmalkapuram/MemtierResultsAggregation branch November 22, 2023 06:57
muskankhedia pushed a commit to muskankhedia/VirtualClient that referenced this pull request Nov 24, 2023
* metrics aggregation starting

* Adding aggregate metrics logic

* Updating aggregation logic and adding vpuid for each process in metricsmetadata as part of commandline

* resolving functional testing, adding documentation, resolving issue with transient error at server side

* resolving UTs

* clean up code

* updating Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants