-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memtier results aggregation #196
Merged
nmalkapuram
merged 7 commits into
main
from
users/nmalkapuram/MemtierResultsAggregation
Nov 22, 2023
Merged
Memtier results aggregation #196
nmalkapuram
merged 7 commits into
main
from
users/nmalkapuram/MemtierResultsAggregation
Nov 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangpanMS
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For metric changes could you please add changes for both metric documents and also the unit test?
src/VirtualClient/VirtualClient.Actions/HPLinpack/HPLinpackExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Memtier/MemtierBenchmarkClientExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Memtier/MemtierBenchmarkClientExecutor.cs
Outdated
Show resolved
Hide resolved
Also please rename the title |
nmalkapuram
changed the title
Users/nmalkapuram/memtier results aggregation
Memtier results aggregation
Nov 1, 2023
nmalkapuram
force-pushed
the
users/nmalkapuram/MemtierResultsAggregation
branch
3 times, most recently
from
November 8, 2023 19:35
4c4e2cb
to
68f9ab9
Compare
yangpanMS
reviewed
Nov 9, 2023
src/VirtualClient/VirtualClient.Actions.UnitTests/Memtier/MemtierMetricsParserTests.cs
Outdated
Show resolved
Hide resolved
yangpanMS
reviewed
Nov 9, 2023
src/VirtualClient/VirtualClient.Actions.UnitTests/Examples/Memtier/RedisResults_3.txt
Show resolved
Hide resolved
nmalkapuram
force-pushed
the
users/nmalkapuram/MemtierResultsAggregation
branch
from
November 15, 2023 04:43
0f841dd
to
f751032
Compare
…csmetadata as part of commandline
…ith transient error at server side
nmalkapuram
force-pushed
the
users/nmalkapuram/MemtierResultsAggregation
branch
from
November 21, 2023 15:59
f751032
to
7df089e
Compare
yangpanMS
approved these changes
Nov 21, 2023
muskankhedia
pushed a commit
to muskankhedia/VirtualClient
that referenced
this pull request
Nov 24, 2023
* metrics aggregation starting * Adding aggregate metrics logic * Updating aggregation logic and adding vpuid for each process in metricsmetadata as part of commandline * resolving functional testing, adding documentation, resolving issue with transient error at server side * resolving UTs * clean up code * updating Unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate metrics for memtier client for both redis and memcached server process.