-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wrathmark to Virtual Client #201
Conversation
src/VirtualClient/VirtualClient.UnitTests/VirtualClient.UnitTests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documents to /website/docs/workloads. Your markdown will automatically be hosted at https://microsoft.github.io/VirtualClient/docs/category/workloads/
src/VirtualClient/VirtualClient.Main/profiles/PERF-CPU-WRATHMARK.json
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Main/profiles/PERF-CPU-WRATHMARK.json
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Main/profiles/PERF-CPU-WRATHMARK.json
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/Wrathmark/WrathmarkTests.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Wrathmark/WrathmarkWorkloadExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Wrathmark/WrathmarkWorkloadExecutor.cs
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/Examples/Wrathmark/TestWrathmark.txt
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/Wrathmark/WrathmarkTests.cs
Outdated
Show resolved
Hide resolved
Please also add one line in /website/docs/overview/overview.md with the basic info and license link |
FWIW I released Wrathmark with a public domain license. No restrictions. The license is in the project. |
Also you don't want to release while it is still pointing at the Vector128 version. That one is horribad. Use the std-arrays version. Peer directory. Same enlistment same change number. |
Talked to @yangpanMS ; we're going to wait until #214 lands next week to merge. The update to .NET 8 for VC has some benefits and we'll use that as the baseline. |
This avoids having to specify pathing when loading benchmarks as everything is relative to the git repo root
Failure appears unrelated to this change.
CC @yangpanMS |
Acknowledged, it's a flaky unit test. I will ignore that in another commit. For now you can rerun PR build and it mostly will pass |
Merged as of |
@yangpanMS Merged as of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed review. Most of the comments are minor and are for consistency.
src/VirtualClient/VirtualClient.Actions.UnitTests/Wrathmark/Constants.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Wrathmark/WrathmarkWorkloadExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Wrathmark/WrathmarkWorkloadExecutor.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions/Wrathmark/WrathmarkMetricsParser.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/Wrathmark/WrathmarkTests.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Actions.UnitTests/Wrathmark/WrathmarkResultParserTests.cs
Outdated
Show resolved
Hide resolved
Add sections on what is being measured and the metric emitted. Signed-off-by: Richard Murillo <[email protected]>
Adds Wrath-Othello from @ricomariani to VirtualClient. This is based on a series of articles published by Rico Part 1 and Part 2
Changes
VirtualClient.UnitTests
internal visibility toVirtualClient.Actions
assemblyWrathmarkMetricsParser
to adapt Wrathmark stdout to Virtual ClientMetric
WrathmarkLoadExecutor
to run the Wrathmark console command