-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating MySql configuration for Optimization #419
Conversation
b9717f3
to
a17b365
Compare
@@ -10,6 +10,7 @@ | |||
"DatabaseName": "sbtest", | |||
"DatabaseScenario": "Balanced", | |||
"DiskFilter": "osdisk:false&sizegreaterthan:256g", | |||
"InnodbBufferPoolSize": "{calculate({SystemMemoryBytes} * 80 / 100)}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you change profile parameters please change document accordingly.
@@ -169,7 +170,7 @@ | |||
"Parameters": { | |||
"Scenario": "DownloadMySqlServerPackage", | |||
"BlobContainer": "packages", | |||
"BlobName": "mysql-server-8.0.36.zip", | |||
"BlobName": "mysql-server-8.0.36-v2.zip", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the changes, need to document what you changed in the package. Also there might be licensing concerns if we modify mysql package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the changes not done to mysql package directly. There are few python scripts we have developed in order to configure and run mysql. I will document the changes made. I was planning to add those scripts in source code too, inorder to have proper version control.
src/VirtualClient/VirtualClient.Main/profiles/PERF-MYSQL-SYSBENCH-OLTP.json
Show resolved
Hide resolved
Also change title accordingly |
Any update on this? Should I close for the time being? |
|
Removing the branch as these changes are added in recently in another PR. |
Updating mysql server package to update the sql configuration (configure.py) to optimize server.
Updating profile for seting up optimal environment variables for mysql server.