Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MySql configuration for Optimization #419

Closed

Conversation

nmalkapuram
Copy link
Contributor

Updating mysql server package to update the sql configuration (configure.py) to optimize server.
Updating profile for seting up optimal environment variables for mysql server.

@nmalkapuram nmalkapuram force-pushed the users/nmalkapuram/sqlconfigupdateforoptimization branch from b9717f3 to a17b365 Compare January 5, 2025 21:29
@@ -10,6 +10,7 @@
"DatabaseName": "sbtest",
"DatabaseScenario": "Balanced",
"DiskFilter": "osdisk:false&sizegreaterthan:256g",
"InnodbBufferPoolSize": "{calculate({SystemMemoryBytes} * 80 / 100)}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you change profile parameters please change document accordingly.

@@ -169,7 +170,7 @@
"Parameters": {
"Scenario": "DownloadMySqlServerPackage",
"BlobContainer": "packages",
"BlobName": "mysql-server-8.0.36.zip",
"BlobName": "mysql-server-8.0.36-v2.zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes, need to document what you changed in the package. Also there might be licensing concerns if we modify mysql package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the changes not done to mysql package directly. There are few python scripts we have developed in order to configure and run mysql. I will document the changes made. I was planning to add those scripts in source code too, inorder to have proper version control.

@yangpanMS
Copy link
Contributor

Also change title accordingly

@nmalkapuram nmalkapuram changed the title Users/nmalkapuram/sqlconfigupdateforoptimization Updating MySql configuration for Optimization Jan 13, 2025
@yangpanMS
Copy link
Contributor

Any update on this? Should I close for the time being?

@nmalkapuram
Copy link
Contributor Author

Any update on this? Should I close for the time being?
Removing the branch as these changes are added in recently in another PR. Thank you.

@nmalkapuram
Copy link
Contributor Author

Removing the branch as these changes are added in recently in another PR.

@nmalkapuram nmalkapuram closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants