Verify network mode test assertions are correct#13915
Closed
Copilot wants to merge 1 commit intouser/ptrivedi/cont-network-modefrom
Closed
Verify network mode test assertions are correct#13915Copilot wants to merge 1 commit intouser/ptrivedi/cont-network-modefrom
Copilot wants to merge 1 commit intouser/ptrivedi/cont-network-modefrom
Conversation
Copilot
AI
changed the title
[WIP] WIP address feedback on container network mode implementation
Verify network mode test assertions are correct
Dec 15, 2025
87b7671 to
606dc8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Verified that the bot's suggestion regarding network mode assertions in WSLATests.cpp has already been correctly implemented. No code changes required.
PR Checklist
Detailed Description of the Pull Request / Additional comments
The automated review suggested changing a test assertion to expect
'[\"none\"]'instead of'[\"host\"]'for a container created withWSLA_CONTAINER_NETWORK_NONE.Current implementation already has this correct:
WSLA_CONTAINER_NETWORK_HOST→ expects'[\"host\"]'(line 1495)WSLA_CONTAINER_NETWORK_NONE→ expects'[\"none\"]'(line 1526)Both assertions correctly match their respective network types. The suggestion appears to reference outdated line numbers from the original PR.
Validation Steps Performed
HOST,NONE) has correct expected network label💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.