-
Notifications
You must be signed in to change notification settings - Fork 708
Replace MainWindow with plain Window in sample projects #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AndrewKeepCoding
wants to merge
2
commits into
microsoft:main
Choose a base branch
from
AndrewKeepCoding:child-window-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−17
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 23 additions & 10 deletions
33
WinUIGallery/Samples/SampleCode/Window/CreateWindowSample1.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| // C# code to create a new window | ||
| var newWindow = WindowHelper.CreateWindow(); | ||
| var rootPage = new NavigationRootPage(); | ||
| rootPage.RequestedTheme = ThemeHelper.RootTheme; | ||
| newWindow.Content = rootPage; | ||
| newWindow.Activate(); | ||
| var childWindow = new Window | ||
| { | ||
| ExtendsContentIntoTitleBar = true, | ||
| SystemBackdrop = new MicaBackdrop(), | ||
| Content = new Page | ||
| { | ||
| // The TreeHelper is a helper class in the WinUIGallery project | ||
| // that allows us to find the current theme of the app. | ||
| RequestedTheme = ThemeHelper.RootTheme, | ||
| Content = new TextBlock | ||
| { | ||
| Text = "New Window!", | ||
| HorizontalAlignment = HorizontalAlignment.Center, | ||
| VerticalAlignment = VerticalAlignment.Center, | ||
| }, | ||
| } | ||
| }; | ||
|
|
||
| // C# code to navigate in the new window | ||
| var targetPageType = typeof(HomePage); | ||
| string targetPageArguments = string.Empty; | ||
| rootPage.Navigate(targetPageType, targetPageArguments); | ||
| childWindow.AppWindow.ResizeClient(new SizeInt32(500, 500)); | ||
|
|
||
| // The WindowHelper is a helper class in the WinUIGallery project | ||
| // that helps us close child windows when the main window closes. | ||
| WindowHelper.TrackWindow(childWindow); | ||
| childWindow.Activate(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this was painful 😅, can't we just create a
NewWindoworSecondaryWindow?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intension was to avoid adding custom code to the sample as much as possible, but sure I can do that.🙂