Eval-driven content fixes: #31, #23, #24, #29 (vally 0.8.0)

[David Pine (IEvangelist)]

Content fixes driven by the vally 0.8.0 eval loop

Stacked on #35 (base branch dapine/skill-evals-vally). Rebased onto the updated
#35 tip, so this branch now inherits the vally 0.8.0 migration and the
scoring: threshold: 0.7 gate blocks on every spec (the missing scoring blocks
were the earlier eval-CI failure cause).

Each fix follows the eval-first red→green loop: add a capability stimulus that
captures the desired behavior, fix the skill content, and verify the stimulus
passes before committing. Rebase onto main once #35 merges.

Issues addressed

Commit	Issue	Summary
b028315	#31	aspireify: reduce await noise in TypeScript AppHost examples — de-await chainable add*/with* calls across the TS/JS references, add a "when you actually need await" section + a Hard Rules anti-pattern row, and a fluent-style stimulus.
915bbf1	#23	aspireify: document the JS monorepo shared-package build pattern — a one-shot shared-build resource consumers waitForCompletion on, waitForCompletion vs waitFor, and the tsc --incremental skip-emit pitfall + prebuild clean fix.
6172885	#24	aspire: add an Aspire 13.4 breaking-changes reference (adopting the distilled content from #25) plus the PostgreSQL 17→18 data-volume incompatibility, wired into the router's References.
d080ff3	#29	aspireify: add Bicep / ARM IaC → AppHost conversion guidance — resource→AddAzure* map, AddBicepTemplate fallback, and the provision-new vs reference-existing decision, with a grounded infra/main.bicep fixture.
6be4a93	#31 (follow-up)	aspireify: explain why un-awaited TS resource vars are still type-correct.

Verification

vally lint skills → 6/6 passing; every spec carries scoring: threshold: 0.7.
Capability stimuli are grounded with real workspace fixtures so the executor
activates the skill and reads the relevant reference rather than answering from
memory. Model-backed eval gating runs in CI on vally 0.8.0.

Fixes #31
Fixes #23
Fixes #24
Fixes #29

[Copilot]

Pull request overview

This PR updates the aspireify and aspire skill content to address eval-driven documentation gaps and correctness issues introduced/validated via the vally 0.8.0 evaluation loop, adding new references and new stimuli/fixtures to gate the intended behaviors.

Changes:

• Updates TypeScript AppHost guidance to prefer fluent *ResourcePromise chaining (minimizing unnecessary await) and adds new eval stimuli to enforce the pattern.
• Adds JavaScript/TypeScript monorepo guidance for source-linked shared packages (one-shot build resource + waitForCompletion, with tsc --incremental caveat) and corresponding eval stimulus.
• Adds new references for Bicep/ARM IaC → AppHost conversion and Aspire 13.4 breaking-change scrubs, plus eval/fixture updates to validate routing and upgrade guidance.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
skills/aspireify/SKILL.md	Adds Bicep conversion reference + scan/propose heuristics; updates TS quick reference to de-await addProject.
skills/aspireify/references/typescript-authoring.md	Rewrites TS examples to avoid over-await; adds an explanation section about fluent promise types.
skills/aspireify/references/javascript-apps.md	De-awaits examples; adds “Shared library packages in monorepos” guidance + pitfall callouts.
skills/aspireify/references/bicep-to-apphost.md	New reference for mapping Bicep/ARM resources to native Aspire APIs with custom-template fallbacks.
skills/aspireify/references/apphost-wiring.md	Updates TS wiring snippets to remove unnecessary await.
skills/aspireify/evals/eval.yaml	Adds/updates stimuli and binary-scored graders for fluent TS style, monorepo shared builds, and IaC conversion.
skills/aspire/SKILL.md	Adds references to the breaking-changes index + new 13.4 scrub list.
skills/aspire/references/aspire-breaking-changes.md	New version-index reference for Aspire breaking changes.
skills/aspire/references/aspire-13-4-breaking-changes.md	New Aspire 13.4 breaking-change scrub list (agent-facing).
skills/aspire/evals/eval.yaml	Adds a 13.4 upgrade stimulus to validate specific breaking-change guidance (incl. PG data volumes).
evals/csharp-apphost/MyApp.Web/Program.cs	New fixture content used by updated aspireify ServiceDefaults stimulus.
evals/csharp-apphost/MyApp.Web/MyApp.Web.csproj	New web project fixture for eval workspace context.
evals/csharp-apphost/MyApp.ApiService/Program.cs	New API service fixture for eval workspace context.
evals/azure-bicep/infra/main.bicep	New Bicep fixture for IaC→AppHost conversion stimulus.

Comments suppressed due to low confidence (1)

skills/aspireify/references/typescript-authoring.md:232

• The YARP Routing snippet uses web.getEndpoint('http') but web is not declared in the example, making the snippet incomplete.

const api = builder.addProject('api', '../Api/Api.csproj');
const yarp = builder.addYarp('gateway')
    .addRoute('/api/{**catch-all}', api.getEndpoint('http'))
    .addCatchAllRoute(web.getEndpoint('http'));

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.