fix(dashboard): hide UTC timestamps option when Show timestamps is off - #19967
Open
Longhao Wang (GISWLH) wants to merge 2 commits into
Open
fix(dashboard): hide UTC timestamps option when Show timestamps is off#19967Longhao Wang (GISWLH) wants to merge 2 commits into
Longhao Wang (GISWLH) wants to merge 2 commits into
Conversation
The console logs settings menu previously showed a disabled UTC timestamps checkbox whenever timestamps were hidden. Hide the option entirely so it only appears when timestamps are enabled. Fixes microsoft#19019
Covers the console logs settings menu so UTC timestamps is absent when Show timestamps is disabled and present after timestamps are enabled.
Longhao Wang (GISWLH)
requested review from
James Newton-King (JamesNK) and
Adam Ratzman (adamint)
as code owners
September 6, 2026 03:03
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19967Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19967" |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The behavior change is small, directly matches the reported UX bug, and includes targeted automated coverage to prevent regression.
Pull request overview
This PR updates the Console Logs settings menu in the Aspire Dashboard so the “UTC timestamps” option is only shown when “Show timestamps” is enabled, aligning the UI with the expected UX described in issue #19019.
Changes:
- Hide the “UTC timestamps” menu item unless timestamps are currently enabled.
- Add a component test covering both the hidden (disabled timestamps) and shown (enabled timestamps) cases.
File summaries
| File | Description |
|---|---|
| src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs | Conditions the “UTC timestamps” menu item on _showTimestamp so it’s hidden when timestamps are off. |
| tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs | Adds a bUnit test validating the UTC menu item is absent when timestamps are off and present after enabling timestamps. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides the UTC timestamps menu item in the logs filter unless Show timestamps is enabled, matching expected UX.
Fixes #19019
Test plan