fix(ci): stop benchmark-only changes from running all tests - #19988
Draft
Ankit Jain (radical) wants to merge 1 commit into
Draft
Conversation
Benchmark projects live outside Aspire.slnx, so Layer 1 cannot attribute their files. With no curated map entry, benchmark-only changes reached the unattributed-file fallback and selected the full PR test matrix even though no PR-CI job consumes these harnesses. Ignore benchmark harness paths in Layer 2. Generalize the real-map invariant to require every tracked project outside Aspire.slnx to be covered by a curated selector rule or a reasoned allow-list, so removing this classification reproduces the ALL fallback regression. Refs microsoft#19986 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a347e4e8-a096-468b-bf78-f88b648c20c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark-only PRs fell through the selector's unattributed-file fallback and forced the full test matrix. The selector reported benchmark project files under:
Both benchmark projects are outside the
Aspire.slnxProjectGraph, and no GitHub PR-CI job consumes either benchmark harness.This classifies
benchmarks/**as intentionally ignored by Layer 2, so benchmark-only changes select no tests or jobs instead ofALL. It also generalizes the real-map invariant to require every tracked project outsideAspire.slnxto be covered by a curated rule or a reasoned allow-list.Verification
Infrastructure.Tests.TestTriggerMap: 218 passedFixes #19986