Use cloud icon for Azure environment - #20011
Use cloud icon for Azure environment#20011Maddy Montaquila (maddymontaquila) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 916598a2-fbff-4cd6-bfbb-d1576396f17f
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20011Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20011" |
github-actions
Bot
added
the
area-integrations
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The behavior is correct and tested; only a minor test-comment convention cleanup remains.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceExtensionsTests.cs — Repository test guidance explicitly prohibits Arrange/Act/Assert comments (AGENTS.md:282). Remove… |
What changed in this PR
Assigns the CloudCube icon to Azure environment resources.
Changes:
- Applies the filled
CloudCubeicon in run and publish modes. - Adds focused annotation coverage.
| File | Description |
|---|---|
src/Aspire.Hosting.Azure/AzureEnvironmentResourceExtensions.cs |
Configures the Azure environment icon. |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceExtensionsTests.cs |
Verifies icon name and variant. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 916598a2-fbff-4cd6-bfbb-d1576396f17f
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The icon configuration is correct, mode-consistent, and covered by a focused test.
Review tier: Balanced
Findings: None
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceExtensionsTests.cs — Repository test guidance explicitly prohibits Arrange/Act/Assert comments (AGENTS.md:282). Remove… View resolved comment |
Tests selector11 / 99 PR test projects · 2 PR jobs · 1 advisory-only target, from 2 changed files. Selected PR test projects (11 / 99)
Selected PR jobs (2)
Advisory workflow impact (1)
How these were chosen — grouped by what changed
🔧 🧪 Job reasons
Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Description
The new
azure-environmentcontrol resource currently uses the dashboard's generic cog fallback, which makes it difficult to distinguish from other unknown resource types. This change assigns the Fluent UICloudCubeicon to better represent an Azure environment that contains and manages cloud resources.User-facing usage
The Resources page now displays a filled cloud-and-cube icon next to the
azure-environmentresource instead of the generic cog.The Azure environment builder test verifies that the resource publishes the expected icon annotation.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?