rysweet-unsubscribe-and-agent-tests-4744#4920
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 105 out of 120 changed files in this pull request and generated 3 comments.
Files not reviewed (15)
- dotnet/AutoGen.sln: Language not supported
- dotnet/Directory.Packages.props: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/DevTeam.AgentHost.csproj: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/Properties/launchSettings.json: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/appsettings.Development.json: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/DevTeam.Agents.csproj: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/Properties/launchSettings.json: Language not supported
- dotnet/samples/dev-team/DevTeam.Agents/appsettings.Development.json: Language not supported
- dotnet/samples/dev-team/DevTeam.AgentHost/Program.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
- dotnet/samples/dev-team/DevTeam.Agents/Program.cs: Evaluated as low risk
- README.md: Evaluated as low risk
- dotnet/samples/Hello/HelloAIAgents/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
dotnet/samples/Hello/HelloAgent/Program.cs:59
- The
SayHellomethod now accepts aCancellationToken, but theHandlemethod does not pass thecancellationTokento it. Ensure that thecancellationTokenis propagated correctly.
public async Task<string> SayHello(string ask, CancellationToken cancellationToken = default)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4920 +/- ##
=======================================
Coverage 70.08% 70.08%
=======================================
Files 179 179
Lines 11620 11620
=======================================
Hits 8144 8144
Misses 3476 3476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jackgerrits
reviewed
Jan 7, 2025
jackgerrits
reviewed
Jan 7, 2025
…breaking connections
…n the HelloAgents sample.
…thods that depended upon them,
jackgerrits
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
adds unsubscribe api
adds tests for most all of Agent and AgentWorker
Related issue number
closes #4744
closes #4357
Checks