Skip to content

Comments

rysweet-unsubscribe-and-agent-tests-4744#4920

Merged
rysweet merged 121 commits intomainfrom
rysweet-4744-bring-over-the-tests-from-pr-4405
Jan 25, 2025
Merged

rysweet-unsubscribe-and-agent-tests-4744#4920
rysweet merged 121 commits intomainfrom
rysweet-4744-bring-over-the-tests-from-pr-4405

Conversation

@rysweet
Copy link
Collaborator

@rysweet rysweet commented Jan 7, 2025

Why are these changes needed?

adds unsubscribe api
adds tests for most all of Agent and AgentWorker

Related issue number

closes #4744
closes #4357

Checks

@rysweet rysweet linked an issue Jan 7, 2025 that may be closed by this pull request
@rysweet rysweet requested a review from Copilot January 7, 2025 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 105 out of 120 changed files in this pull request and generated 3 comments.

Files not reviewed (15)
  • dotnet/AutoGen.sln: Language not supported
  • dotnet/Directory.Packages.props: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/DevTeam.AgentHost.csproj: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/Properties/launchSettings.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/appsettings.Development.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/DevTeam.Agents.csproj: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/Properties/launchSettings.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.Agents/appsettings.Development.json: Language not supported
  • dotnet/samples/dev-team/DevTeam.AgentHost/Program.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/Developer/Developer.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/ProductManager/ProductManager.cs: Evaluated as low risk
  • dotnet/samples/dev-team/DevTeam.Agents/Program.cs: Evaluated as low risk
  • README.md: Evaluated as low risk
  • dotnet/samples/Hello/HelloAIAgents/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

dotnet/samples/Hello/HelloAgent/Program.cs:59

  • The SayHello method now accepts a CancellationToken, but the Handle method does not pass the cancellationToken to it. Ensure that the cancellationToken is propagated correctly.
public async Task<string> SayHello(string ask, CancellationToken cancellationToken = default)

@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (55e929d) to head (da4923a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4920   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files         179      179           
  Lines       11620    11620           
=======================================
  Hits         8144     8144           
  Misses       3476     3476           
Flag Coverage Δ
unittests 70.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rysweet rysweet marked this pull request as ready for review January 25, 2025 01:43
@rysweet rysweet merged commit b6597fd into main Jan 25, 2025
66 checks passed
@rysweet rysweet deleted the rysweet-4744-bring-over-the-tests-from-pr-4405 branch January 25, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bring over the tests from pr 4405 Implement remove_subscription in worker runtime

5 participants