Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl remove and get subscription APIs for python xlang #5365

Merged
merged 9 commits into from
Feb 11, 2025
Merged

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Feb 4, 2025

Closes #5297

@jackgerrits jackgerrits changed the title Impl remove and get subscription APIs Impl remove and get subscription APIs for python xlang Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (392aa14) to head (14f16e4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ext/runtimes/grpc/_worker_runtime_host_servicer.py 77.77% 2 Missing ⚠️
...gen-core/src/autogen_core/_runtime_impl_helpers.py 75.00% 1 Missing ⚠️
...t/src/autogen_ext/runtimes/grpc/_worker_runtime.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5365      +/-   ##
==========================================
+ Coverage   73.57%   78.35%   +4.78%     
==========================================
  Files         205      167      -38     
  Lines       11011     9923    -1088     
  Branches      146        0     -146     
==========================================
- Hits         8101     7775     -326     
+ Misses       2815     2148     -667     
+ Partials       95        0      -95     
Flag Coverage Δ
unittests 78.35% <77.77%> (+4.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu merged commit dc877d5 into main Feb 11, 2025
67 checks passed
@ekzhu ekzhu deleted the grpc_impl_py branch February 11, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl remove scription and get subscription for python rpc
4 participants