Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MCP tool bug by dropping unset parameters from input #6125

Merged
merged 10 commits into from
Mar 27, 2025
Merged

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Mar 27, 2025

Resolves #6096

Additionally: make sure MCP errors are formatted correctly, added unit tests for mcp servers and upgrade mcp version.

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekzhu

@ekzhu ekzhu enabled auto-merge (squash) March 27, 2025 00:40
@ekzhu ekzhu disabled auto-merge March 27, 2025 04:19
@ekzhu ekzhu enabled auto-merge (squash) March 27, 2025 17:57
@ekzhu ekzhu disabled auto-merge March 27, 2025 20:02
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 76.90%. Comparing base (b5ff7ee) to head (a629a4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/autogen-ext/src/autogen_ext/tools/mcp/_base.py 46.66% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
- Coverage   76.94%   76.90%   -0.05%     
==========================================
  Files         191      191              
  Lines       13381    13387       +6     
==========================================
- Hits        10296    10295       -1     
- Misses       3085     3092       +7     
Flag Coverage Δ
unittests 76.90% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu ekzhu merged commit 29485ef into main Mar 27, 2025
56 of 57 checks passed
@ekzhu ekzhu deleted the ekzhu-fix-mcp-tool branch March 27, 2025 20:22
ekzhu added a commit that referenced this pull request Mar 29, 2025
Resolves #6096

Additionally: make sure MCP errors are formatted correctly, added unit
tests for mcp servers and upgrade mcp version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autogen MCP : Error: unhandled errors in a TaskGroup (1 sub-exception) using Autogen and gpt-4o.
3 participants