Add VM Tests for Fedora 42 #461
Open
+225
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
b1f9eae to
4eee2ab
Compare
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
4eee2ab to
7d99721
Compare
cwize1
reviewed
Oct 3, 2025
| # Download the test RPM and tools file for azurelinux | ||
| ./repo/toolkit/tools/internal/testutils/testrpms/download-test-utils.sh -d azurelinux -t 3.0 -s true | ||
| # Download the test RPM and tools file for fedora | ||
| ./repo/toolkit/tools/internal/testutils/testrpms/download-test-utils.sh -d fedora -t 42 -s true |
There was a problem hiding this comment.
The Fedora container image is currently being pulled from registry.fedoraproject.org. Pulling from an external registry is bad for a number of reasons including:
- The reliability of our builds becomes dependent on the uptime on the external resource,
- We are consuming someone else's resources (e.g. egress costs),
- We may end up being subject to pull limits.
We should setup an ACR artifact cache for registry.fedoraproject.org.
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
7d99721 to
a4b5d74
Compare
cwize1
reviewed
Oct 3, 2025
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
a4b5d74 to
fc9c1a6
Compare
cwize1
requested changes
Oct 6, 2025
|
|
||
| with open(os_release_path, "r") as os_release_fd: | ||
| os_release_text = os_release_fd.read() | ||
| logging.info("OS Release content:") |
There was a problem hiding this comment.
Use a single call to log something, to avoid logs messages from being split up if there is something in the background adding to the logs.
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
3 times, most recently
from
b6441ef to
a08147c
Compare
cwize1
requested changes
Oct 7, 2025
| ssh_client.run("rpm -q grub2").check_exit_code() | ||
| ssh_client.run("rpm -q bash").check_exit_code() | ||
| # Check required packages | ||
| package_list = [str(pkg) for pkg in config["packages"]] |
| # Download the test RPM and tools file for azurelinux | ||
| ./repo/toolkit/tools/internal/testutils/testrpms/download-test-utils.sh -d azurelinux -t 3.0 -s true | ||
| # Download the test RPM and tools file for fedora | ||
| ./repo/toolkit/tools/internal/testutils/testrpms/download-test-utils.sh -d fedora -t 42 -s true |
vinceaperri
reviewed
Oct 7, 2025
| --show-capture=all \ | ||
| --tb=short \ | ||
| --junitxml=./out/$(DATETIME_AS_VERSION)/report.xml \ | ||
| ./vmtests/imagecreator/test_imagecreator.py |
There was a problem hiding this comment.
Should this file be renamed to test_imagecreator_azurelinux.py to maintain parallel nature of your changes?
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
a08147c to
0aa141d
Compare
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
3 times, most recently
from
3ff85f3 to
bbd5634
Compare
himaja-kesari
force-pushed
the
user/himajakesari/vmtests-fedora42
branch
from
bbd5634 to
7c07369
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Fedora 42 Support to VM Tests
This PR adds support for running VM tests with Fedora 42 images.
Changes
test-imagecreator-fedora: Runs only Fedora teststest-imagecreator-azurelinux: Runs only Azure Linux tests