Skip to content

Patch grpc for CVE-2023-31130 [Medium] #11977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025
Merged

Conversation

suresh-thelkar
Copy link
Contributor

@suresh-thelkar suresh-thelkar commented Jan 17, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Patch CVE-2023-31130 in grpc

Change Log
  • CVE-2023-31130
Does this affect the toolchain?

YES/NO

Associated issues
  • NA
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Jan 17, 2025
@suresh-thelkar suresh-thelkar marked this pull request as ready for review January 20, 2025 09:04
@suresh-thelkar suresh-thelkar requested a review from a team as a code owner January 20, 2025 09:04
@suresh-thelkar suresh-thelkar marked this pull request as draft January 20, 2025 09:06
@suresh-thelkar suresh-thelkar marked this pull request as ready for review April 7, 2025 08:50
@Kanishk-Bansal Kanishk-Bansal changed the title Patch CVE-2023-31130 in grpc Patch grpc for CVE-2023-31130 [Medium] Apr 7, 2025
From: Brad House <[email protected]>
Date: Mon, 22 May 2023 06:51:34 -0400
Subject: [PATCH] Merge pull request from GHSA-x6mf-cxr9-8q6v

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Upstream Patch Reference : https://github.com/c-ares/c-ares/commit/f22cc01039b6473b736d3bf438f56a2654cdf2b2.patch

Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Buddy Build
  • Is the patch applied during the build (check rpm.log)?
  • Are all test failures (if any) addressed?
  • Does the patch include an upstream reference?
  • Does the PR has security tag?

@suresh-thelkar
Copy link
Contributor Author

thanks @Kanishk-Bansal for the review. I have added upstream patch details as well.

@jslobodzian jslobodzian merged commit 9e05142 into fasttrack/2.0 Apr 7, 2025
9 of 13 checks passed
@jslobodzian jslobodzian deleted the sthelkar/grpc_2.0 branch April 7, 2025 19:10
@CBL-Mariner-Bot
Copy link
Collaborator

Auto cherry-pick results:

  • main ✅ -> Skipped

Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=781713&view=results

jslobodzian added a commit that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants