-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup BASH_ENV and zshenv #72
base: main
Are you sure you want to change the base?
Conversation
`.zshenv` is sourced by all zsh shells (interactive/non-interactive/login). Where `.zshrc` is only sourced by interactive shells. To prevent users from having to be aware of auth wrappers, using `.zshenv` will help reduce friction for users.
BASH_ENV is a variable used for identifying a script that should be sourced before launch bash scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/artifacts-helper/install.sh: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Looks good overall. Can you update to bump the version to 2.0.4 and also review the content at the end of NOTES.md to see if there are any additional items about BASH_ENV you want to add to that documentation? What scenario is this improving? It sounds like when a bash script runs a tool like npm or dotnet? I've also observed other scenarios like when a node app or some other code runs those tools without using a bash script. For example, the VS Code C# DevKit extension runs |
This is correct, when running a bash script, the script will source the
The current solution does not work here... but I wonder if leveraging
From docker:
I believe, then all bash scripts should see
|
BASH_ENV is a variable used for identifying a script that should be sourced when launching bash scripts.
zshenv is always sourced by zsh in interactive and non-interactive modes.
This makes it so that the auth wrapping functions are available in bash and zsh scripts.