Skip to content

ci: refactor Notification formatting#779

Open
Vamshi-Microsoft wants to merge 2 commits intomainfrom
psl-update-notifications
Open

ci: refactor Notification formatting#779
Vamshi-Microsoft wants to merge 2 commits intomainfrom
psl-update-notifications

Conversation

@Vamshi-Microsoft
Copy link
Contributor

Purpose

This pull request updates the deployment orchestrator workflow to improve resource cleanup handling and notification logic. The main changes focus on integrating the cleanup job more tightly with the workflow, ensuring its result is available for notifications, and making notification inputs more robust.

Workflow improvements:

  • Added the cleanup-deployment job to .github/workflows/deploy-orchestrator.yml, which runs conditionally after deployment and testing to clean up resources. Its outputs are now passed to the notification job.
  • Updated the send-notification job to depend on the cleanup-deployment job and to include the cleanup_result output, allowing notification logic to reflect the cleanup status. [1] [2]

Notification input enhancements:

  • Made the e2e_test_result input optional with a default value in .github/workflows/job-send-notification.yml to handle cases where E2E tests may not run.
  • Added a new optional cleanup_result input to .github/workflows/job-send-notification.yml, defaulting to 'skipped', so notifications can report cleanup job outcomes.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant