Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment orchestrator workflow to improve resource cleanup handling and notification logic. The main changes focus on integrating the cleanup job more tightly with the workflow, ensuring its result is available for notifications, and making notification inputs more robust.
Workflow improvements:
cleanup-deploymentjob to.github/workflows/deploy-orchestrator.yml, which runs conditionally after deployment and testing to clean up resources. Its outputs are now passed to the notification job.send-notificationjob to depend on thecleanup-deploymentjob and to include thecleanup_resultoutput, allowing notification logic to reflect the cleanup status. [1] [2]Notification input enhancements:
e2e_test_resultinput optional with a default value in.github/workflows/job-send-notification.ymlto handle cases where E2E tests may not run.cleanup_resultinput to.github/workflows/job-send-notification.yml, defaulting to'skipped', so notifications can report cleanup job outcomes.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information